[WPE][GTK] Introduce WPE 2.0 API version, and ENABLE_2022_GLIB_API flag to indicate either GTK 4 or WPE 2.0 #3886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 4bfbc80) |
mcatanzaro
force-pushed
the
eng/WPEGTK-Introduce-WPE-2-0-API-version-and-ENABLE_2022_GLIB_API-flag-to-indicate-either-GTK-4-or-WPE-2-0
branch
from
4bfbc80
to
c632de1
Compare
|
EWS run on previous version of this PR (hash c632de1) |
webkit-ews-buildbot
added
the
merging-blocked
mcatanzaro
removed
the
merging-blocked
mcatanzaro
force-pushed
the
eng/WPEGTK-Introduce-WPE-2-0-API-version-and-ENABLE_2022_GLIB_API-flag-to-indicate-either-GTK-4-or-WPE-2-0
branch
3 times, most recently
from
c03d3ee
to
a579de6
Compare
webkit-ews-buildbot
added
the
merging-blocked
|
EWS run on previous version of this PR (hash a579de6) |
aperezdc
approved these changes
Sep 12, 2022
mcatanzaro
added
merge-queue
mcatanzaro
force-pushed
the
eng/WPEGTK-Introduce-WPE-2-0-API-version-and-ENABLE_2022_GLIB_API-flag-to-indicate-either-GTK-4-or-WPE-2-0
branch
from
a579de6
to
898bec6
Compare
…ag to indicate either GTK 4 or WPE 2.0 https://bugs.webkit.org/show_bug.cgi?id=244641 Reviewed by Adrian Perez de Castro. Since there are few users of the WPE 1.1 API, and we don't need to keep it around, WPE 2.0 will simply replace WPE 1.1. In contrast, the WPE 1.0 API is still required until Igalia is ready to phase out libsoup 2. With a new API version, I will be able to start breaking things in subsequent commits. I've also fixed some misleading code in OptionsWPE.cmake where option dependencies were located under an unrelated comment, intermixed with option definitions. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/254653@main
webkit-early-warning-system
force-pushed
the
eng/WPEGTK-Introduce-WPE-2-0-API-version-and-ENABLE_2022_GLIB_API-flag-to-indicate-either-GTK-4-or-WPE-2-0
branch
from
898bec6
to
b2a6414
Compare
|
Committed 254653@main (b2a6414): https://commits.webkit.org/254653@main Reviewed commits have been landed. Closing PR #3886 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
lauromoura
added a commit
to lauromoura/cog
that referenced
this pull request
Sep 21, 2022
Following upstream WPE changes in WebKit/WebKit#3886
aperezdc
pushed a commit
to Igalia/cog
that referenced
this pull request
Sep 22, 2022
Following upstream WPE changes in WebKit/WebKit#3886
mcatanzaro
deleted the
eng/WPEGTK-Introduce-WPE-2-0-API-version-and-ENABLE_2022_GLIB_API-flag-to-indicate-either-GTK-4-or-WPE-2-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b2a6414
898bec6
🛠 mac🛠 mac-debug🛠 gtk🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress