Web Inspector: Assertion when removing event listener in CSSPropertyNameCompletions.js #3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaliman-apple
requested review from
dcrousso and
patrickangle
as code owners
rcaliman-apple
added
Web Inspector
|
EWS run on previous version of this PR (hash a6dc0d1)
|
patrickangle
approved these changes
Sep 1, 2022
|
Nit: in commit message: |
rcaliman-apple
force-pushed
the
eng/Web-Inspector-Assertion-when-removing-event-listener-in-CSSPropertyNameCompletions-js
branch
from
a6dc0d1
to
808b938
Compare
rcaliman-apple
added
the
merge-queue
|
…ameCompletions.js https://bugs.webkit.org/show_bug.cgi?id=240606 Reviewed by Patrick Angle. When reloading the page with Web Inspector open: - the map of `WI.DOMNodeStyles` is cleared in `WI.CSSManager._mainResourceDidChange()`; - the selected node is re-selected and a new `WI.DOMNode` is created for it; - the event `WI.DOMManager.Event.InspectedNodeChanged` is dispatched with the data payload member `lastInspectedNode` pointing to this new instance; When requesting the `WI.cssManager.stylesForNode(event.data.lastInspectedNode)`, a new instance of `WI.DOMNodeStyles` is created and returned. This new instance did not have an event listener attached for `WI.DOMNodeStyles.Event.NeedsRefresh`. Therefore, when attempting to remove the event listener, the assertion is hit. This patch makes `CSSPropertyNameCompletions` hold its own reference to the inspected node's `WI.DOMNodeStyles` and remove to reliably remove the event listener. * Source/WebInspectorUI/UserInterface/Models/CSSPropertyNameCompletions.js: (WI.CSSPropertyNameCompletions.prototype._handleInspectedNodeChanged): Canonical link: https://commits.webkit.org/254072@main
webkit-early-warning-system
force-pushed
the
eng/Web-Inspector-Assertion-when-removing-event-listener-in-CSSPropertyNameCompletions-js
branch
from
808b938
to
7d37933
Compare
|
Committed 254072@main (7d37933): https://commits.webkit.org/254072@main Reviewed commits have been landed. Closing PR #3920 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
rcaliman-apple
deleted the
eng/Web-Inspector-Assertion-when-removing-event-listener-in-CSSPropertyNameCompletions-js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7d37933
808b938
🛠 wpe🛠 ios-sim🛠 mac-debug🧪 ios-wk2🛠 mac-AS-debug🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🛠 tv🧪 mac-wk1🛠 tv-sim🧪 mac-wk2🛠 watch🧪 mac-AS-debug-wk2🛠 watch-sim🧪 mac-wk2-stress