Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLib] Fix build with CMake < 3.17 #3968

Merged
merged 1 commit into from
Sep 2, 2022
Merged

[GLib] Fix build with CMake < 3.17 #3968

merged 1 commit into from
Sep 2, 2022

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Sep 2, 2022 •
edited by webkit-early-warning-system

@mcatanzaro mcatanzaro self-assigned this Sep 2, 2022
@webkit-early-warning-system
Copy link
Collaborator

66f0d1e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim   🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim   🧪 mac-wk2-stress

@mcatanzaro mcatanzaro added WebKit Nightly Build WebKitGTK Bugs related to the Gtk API layer. labels Sep 2, 2022
@mcatanzaro mcatanzaro requested review from zdobersek and a team September 2, 2022 21:54
@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Sep 2, 2022
@mcatanzaro
[GLib] Fix build with CMake < 3.17
6be2817 
https://bugs.webkit.org/show_bug.cgi?id=244728

Reviewed by Adrian Perez de Castro.

* Source/WebKit/PdfJSGResources.cmake:

Canonical link: https://commits.webkit.org/254121@main
@webkit-commit-queue
Copy link
Collaborator

Committed 254121@main (6be2817): https://commits.webkit.org/254121@main

Reviewed commits have been landed. Closing PR #3968 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 6be2817 into WebKit:main Sep 2, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

@zdobersek zdobersek Awaiting requested review from zdobersek

Assignees

@mcatanzaro mcatanzaro

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
4 participants
@mcatanzaro @webkit-early-warning-system @webkit-commit-queue @aperezdc