Account for zoom when computing SVG font size #4011

Ahmad-S792 · 2022-09-04T21:41:05Z

Account for zoom when computing SVG font size

https://bugs.webkit.org/show_bug.cgi?id=118818

Reviewed by NOBODY (OOPS!).

Merge - https://chromium.googlesource.com/chromium/blink/+/5624c6e475af92d541edc8a3394602e320d00323 & https://src.chromium.org/viewvc/blink?view=revision&revision=180995 & https://src.chromium.org/viewvc/blink?view=revision&revision=154004

Previously, text that was zoomed appeared larger than geometry under the same zoom value. This was caused by two bugs:
1) When setting the computed font size, we incorrectly referenced the computedTextSize instead of the specified size.
2) Text with GeometricPrecision did not set a computed size but instead relied on the text size being correct.

Further, it also fixes an issue about optimization in RenderSVGInlineText::computeNewScaledFontForStyle would skip updating the font size on lowdpi devices while zooming. The computed font size calculation depends on zoom and the font scaling factor depends on the device's scaling factor. Previously, we would skip updating the font when the scaling factor was 1 which would fail to account for zoom. This patch updates the optimization to only be used when both the scaling factor and zoom are 1.

This change addresses both of these issues and adds a test to prove correctness.

SVG doesn't scale zoomed font units so zooming should not affect font sizes. This patch fixes a bug where em lengths were resolved against the style's font size (with zoom) instead of the specified font size (without zoom).

* Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:
(RenderSVGInlineText::computedNewScaledFontForStyle) - Updated Scaling factor to be accounted into two buckets: 1) GeometricPrecision 2) computedTextSize being referred 3) Use DoNotUseSmartMinimumForFontSize 4) Also fix low DPI issue
* Source/WebCore/svg/SVGLengthContext.cpp: Update "convertValueFromUserUnitsToEMS" and "convertValueFromEMSToUserUnits" to use "specifiedFontSize" rather than "computedFontPixelSize"
* LayoutTests/svg/zoom/text/zoom-text-geometry.html: Added Test Case
* LayoutTests/svg/zoom/text/zoom-text-geometry-expected.html: Added Test Case Expectations
* LayoutTests/svg/zoom/text/lowdpi-zoom-text.html: Added Test Case
* LayoutTests/svg/texst/lowdpi-zoom-text-expected.txt: Added Test Case Expectations
* LayoutTets/svg/zoom/text/zoom-em-units.html: Added Test Case
* LayoutTets/svg/zoom/text/zoom-em-units-expected.html: Added Test Case Expectations

488e2eb

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	💥 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	⏳ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-04T21:43:12Z

EWS run on previous version of this PR (hash 7a165c8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-06T05:00:29Z

EWS run on previous version of this PR (hash 971ee85)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-08T21:53:45Z

EWS run on previous version of this PR (hash 2cbd139)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

Ahmad-S792 · 2022-09-09T08:18:13Z

@smfr & @nikolaszimmermann - Can you guide or suggest on how to fix this 'ios-wk2' failure (svg/text/font-small-enlarged-minimum-larger.svg)?

webkit-early-warning-system · 2022-09-10T19:38:49Z

EWS run on previous version of this PR (hash dd62d17)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-10T20:45:15Z

EWS run on previous version of this PR (hash e71775a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-16T07:46:37Z

EWS run on previous version of this PR (hash d8b31c6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	⏳ 🧪 api-mac	~~🧪 api-gtk~~
	✅ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-16T10:45:56Z

EWS run on previous version of this PR (hash 3a63c84)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-16T14:09:32Z

EWS run on previous version of this PR (hash ee073ca)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

nikolaszimmermann · 2022-09-16T19:52:25Z

Sorry for not responding at all - I'm pretty busy these days...

LayoutTests/svg/text/font-small-enlarged-minimum-larger-expected.html

Source/WebCore/rendering/svg/RenderSVGInlineText.cpp

nikolaszimmermann

Thanks for tackling this -- not ready though, the LayoutTests changes seem fishy.

Ahmad-S792 · 2022-09-17T07:32:17Z

Thanks for tackling this -- not ready though, the LayoutTests changes seem fishy.

Replied above and would appreciate your guidance because I am able to pass all changes by adding 'font-size: 80' but only fails in iOS-wk2 and have asked for input from Simon and he referred that it might be iOS device scaling factor and I should look into hidpi test cases.

webkit-early-warning-system · 2022-09-17T12:22:27Z

EWS run on previous version of this PR (hash e6ebd1a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-19T07:46:42Z

EWS run on previous version of this PR (hash f958ea2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	⏳ 🛠 mac	~~🛠 wpe~~	~~🛠 🧪 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	~~🛠 gtk~~	~~🛠 wincairo~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	⏳ 🧪 api-mac	~~🧪 api-gtk~~
	❌ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	❌ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	❌ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-19T08:06:33Z

EWS run on previous version of this PR (hash ee3acf9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-19T12:58:04Z

EWS run on previous version of this PR (hash 6a007a4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

LayoutTests/svg/text/font-small-enlarged-minimum-larger-expected.svg

LayoutTests/platform/ios/svg/text/font-small-enlarged-minimum-larger-expected.svg

webkit-early-warning-system · 2022-09-21T19:40:48Z

EWS run on previous version of this PR (hash 2dbdf5c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

nikolaszimmermann

That looks good - let's wait for EWS results. If ok, I'll r+ it. Thanks @Ahmad-S792 for your patience.

Ahmad-S792 · 2022-09-21T19:44:31Z

That looks good - let's wait for EWS results. If ok, I'll r+ it. Thanks @Ahmad-S792 for your patience.

No worries - I should appreciate you to deal with noob like me. :-)

I am just learning day by day and have day job so some time response take some time. :-)

Account for zoom when computing SVG font size https://bugs.webkit.org/show_bug.cgi?id=118818 Reviewed by NOBODY (OOPS!). Merge - https://chromium.googlesource.com/chromium/blink/+/5624c6e475af92d541edc8a3394602e320d00323 & https://src.chromium.org/viewvc/blink?view=revision&revision=180995 & https://src.chromium.org/viewvc/blink?view=revision&revision=154004 Previously, text that was zoomed appeared larger than geometry under the same zoom value. This was caused by two bugs: 1) When setting the computed font size, we incorrectly referenced the computedTextSize instead of the specified size. 2) Text with GeometricPrecision did not set a computed size but instead relied on the text size being correct. Further, it also fixes an issue about optimization in RenderSVGInlineText::computeNewScaledFontForStyle would skip updating the font size on lowdpi devices while zooming. The computed font size calculation depends on zoom and the font scaling factor depends on the device's scaling factor. Previously, we would skip updating the font when the scaling factor was 1 which would fail to account for zoom. This patch updates the optimization to only be used when both the scaling factor and zoom are 1. This change addresses both of these issues and adds a test to prove correctness. SVG doesn't scale zoomed font units so zooming should not affect font sizes. This patch fixes a bug where em lengths were resolved against the style's font size (with zoom) instead of the specified font size (without zoom). * Source/WebCore/rendering/svg/RenderSVGInlineText.cpp: (RenderSVGInlineText::computedNewScaledFontForStyle) - Updated Scaling factor to be accounted into two buckets: 1) GeometricPrecision 2) computedTextSize being referred 3) Use DoNotUseSmartMinimumForFontSize 4) Also fix low DPI issue * Source/WebCore/svg/SVGLengthContext.cpp: Update "convertValueFromUserUnitsToEMS" and "convertValueFromEMSToUserUnits" to use "specifiedFontSize" rather than "computedFontPixelSize" * LayoutTests/svg/zoom/text/zoom-text-geometry.html: Added Test Case * LayoutTests/svg/zoom/text/zoom-text-geometry-expected.html: Added Test Case Expectations * LayoutTests/svg/zoom/text/lowdpi-zoom-text.html: Added Test Case * LayoutTests/svg/texst/lowdpi-zoom-text-expected.txt: Added Test Case Expectations * LayoutTets/svg/zoom/text/zoom-em-units.html: Added Test Case * LayoutTets/svg/zoom/text/zoom-em-units-expected.html: Added Test Case Expectations

webkit-early-warning-system · 2022-09-29T23:01:15Z

EWS run on current version of this PR (hash 488e2eb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	💥 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	⏳ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

Ahmad-S792 · 2022-10-17T08:55:59Z

As discussed with @nikolaszimmermann over Slack, there is another change, which we require prior to landing this. So I will work on it and then have similar to this another PR to land this in future hoping that EWS does not reflect same failures.

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 5, 2022

Ahmad-S792 force-pushed the fix118818 branch from 7a165c8 to 971ee85 Compare September 6, 2022 05:00

Ahmad-S792 force-pushed the fix118818 branch from 971ee85 to 2cbd139 Compare September 8, 2022 21:53

Ahmad-S792 force-pushed the fix118818 branch 2 times, most recently from 971c72d to dd62d17 Compare September 10, 2022 19:38

Ahmad-S792 force-pushed the fix118818 branch from dd62d17 to e71775a Compare September 10, 2022 20:44

Ahmad-S792 requested review from smfr, shallawa and nikolaszimmermann September 15, 2022 20:26

Ahmad-S792 self-assigned this Sep 15, 2022

Ahmad-S792 added WebKit Nightly Build SVG For bugs in the SVG implementation. labels Sep 15, 2022

Ahmad-S792 force-pushed the fix118818 branch from e71775a to d8b31c6 Compare September 16, 2022 07:46

Ahmad-S792 force-pushed the fix118818 branch from d8b31c6 to 3a63c84 Compare September 16, 2022 10:45

Ahmad-S792 force-pushed the fix118818 branch from 3a63c84 to ee073ca Compare September 16, 2022 14:09

nikolaszimmermann reviewed Sep 16, 2022

View reviewed changes

LayoutTests/svg/text/font-small-enlarged-minimum-larger-expected.html Outdated Show resolved Hide resolved

nikolaszimmermann reviewed Sep 16, 2022

View reviewed changes

Source/WebCore/rendering/svg/RenderSVGInlineText.cpp Outdated Show resolved Hide resolved

nikolaszimmermann requested changes Sep 16, 2022

View reviewed changes

Ahmad-S792 force-pushed the fix118818 branch from ee073ca to e6ebd1a Compare September 17, 2022 12:22

Ahmad-S792 requested a review from nikolaszimmermann September 17, 2022 12:24

Ahmad-S792 force-pushed the fix118818 branch from e6ebd1a to f958ea2 Compare September 19, 2022 07:46

Ahmad-S792 force-pushed the fix118818 branch from f958ea2 to ee3acf9 Compare September 19, 2022 08:06

Ahmad-S792 force-pushed the fix118818 branch from ee3acf9 to 6a007a4 Compare September 19, 2022 12:57

nikolaszimmermann reviewed Sep 21, 2022

View reviewed changes

LayoutTests/svg/text/font-small-enlarged-minimum-larger-expected.svg Outdated Show resolved Hide resolved

nikolaszimmermann reviewed Sep 21, 2022

View reviewed changes

LayoutTests/platform/ios/svg/text/font-small-enlarged-minimum-larger-expected.svg Outdated Show resolved Hide resolved

Ahmad-S792 force-pushed the fix118818 branch from 6a007a4 to 2dbdf5c Compare September 21, 2022 19:40

nikolaszimmermann reviewed Sep 21, 2022

View reviewed changes

Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Sep 21, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 22, 2022

Ahmad-S792 force-pushed the fix118818 branch from 2dbdf5c to 488e2eb Compare September 29, 2022 23:01

Ahmad-S792 closed this Oct 17, 2022

Ahmad-S792 deleted the fix118818 branch December 9, 2022 01:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Account for zoom when computing SVG font size #4011

Account for zoom when computing SVG font size #4011

Ahmad-S792 commented Sep 4, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 4, 2022 •

edited

webkit-early-warning-system commented Sep 6, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

Ahmad-S792 commented Sep 9, 2022

webkit-early-warning-system commented Sep 10, 2022 •

edited

webkit-early-warning-system commented Sep 10, 2022 •

edited

webkit-early-warning-system commented Sep 16, 2022 •

edited

webkit-early-warning-system commented Sep 16, 2022 •

edited

webkit-early-warning-system commented Sep 16, 2022 •

edited

nikolaszimmermann commented Sep 16, 2022

nikolaszimmermann left a comment

Ahmad-S792 commented Sep 17, 2022

webkit-early-warning-system commented Sep 17, 2022 •

edited

webkit-early-warning-system commented Sep 19, 2022 •

edited

webkit-early-warning-system commented Sep 19, 2022 •

edited

webkit-early-warning-system commented Sep 19, 2022 •

edited

webkit-early-warning-system commented Sep 21, 2022 •

edited

nikolaszimmermann left a comment

Ahmad-S792 commented Sep 21, 2022

webkit-early-warning-system commented Sep 29, 2022 •

edited

Ahmad-S792 commented Oct 17, 2022

Account for zoom when computing SVG font size #4011

Account for zoom when computing SVG font size #4011

Conversation

Ahmad-S792 commented Sep 4, 2022 • edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 4, 2022 • edited

webkit-early-warning-system commented Sep 6, 2022 • edited

webkit-early-warning-system commented Sep 8, 2022 • edited

Ahmad-S792 commented Sep 9, 2022

webkit-early-warning-system commented Sep 10, 2022 • edited

webkit-early-warning-system commented Sep 10, 2022 • edited

webkit-early-warning-system commented Sep 16, 2022 • edited

webkit-early-warning-system commented Sep 16, 2022 • edited

webkit-early-warning-system commented Sep 16, 2022 • edited

nikolaszimmermann commented Sep 16, 2022

nikolaszimmermann left a comment

Choose a reason for hiding this comment

Ahmad-S792 commented Sep 17, 2022

webkit-early-warning-system commented Sep 17, 2022 • edited

webkit-early-warning-system commented Sep 19, 2022 • edited

webkit-early-warning-system commented Sep 19, 2022 • edited

webkit-early-warning-system commented Sep 19, 2022 • edited

webkit-early-warning-system commented Sep 21, 2022 • edited

nikolaszimmermann left a comment

Choose a reason for hiding this comment

Ahmad-S792 commented Sep 21, 2022

webkit-early-warning-system commented Sep 29, 2022 • edited

Ahmad-S792 commented Oct 17, 2022

Ahmad-S792 commented Sep 4, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 4, 2022 •

edited

webkit-early-warning-system commented Sep 6, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 10, 2022 •

edited

webkit-early-warning-system commented Sep 10, 2022 •

edited

webkit-early-warning-system commented Sep 16, 2022 •

edited

webkit-early-warning-system commented Sep 16, 2022 •

edited

webkit-early-warning-system commented Sep 16, 2022 •

edited

webkit-early-warning-system commented Sep 17, 2022 •

edited

webkit-early-warning-system commented Sep 19, 2022 •

edited

webkit-early-warning-system commented Sep 19, 2022 •

edited

webkit-early-warning-system commented Sep 19, 2022 •

edited

webkit-early-warning-system commented Sep 21, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited