WebKit ignores the nowrap on td nowrap="nowrap", if an absolute width is specified #4114

Ahmad-S792 · 2022-09-07T23:43:31Z

WebKit ignores the nowrap on td nowrap="nowrap", if an absolute width is specified

https://bugs.webkit.org/show_bug.cgi?id=183642

Merge - https://chromium.googlesource.com/chromium/src/+/5e6c851254f90f6f495713f7248ffe9a155de413

Previously we only applied it when a 'td' element had no fixed-width. This was incorrect behavior and it will align Webkit with Blink and Gecko for Web interop.

* Source/WebCore/html/HTMLTableCellElement.cpp (HTMLTableCellElement::hasPresentationalHintsForAttribute) - Update nowrap Attribute to respect CSSValueNowrap rather than CSSValueWebkitNowrap
* Source/WebCore/style/StyleAdjuster.cpp (Adjuster:adjust) - Removed logic about td tag only accepting wrap for Fixed Width
* LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-nowrap-minimum-width-calculation-expected.txt - Updated Test Expectations
* LayoutTests/platform/gtk/fast/table/003-expected.png - Updated Test Expectations
* LayoutTests/platform/gtk/fast/table/003-expected.txt - Updated Test Expectations
* LayoutTests/platform/gtk/fast/tables/021-expected.png - Updated Test Expectations
* LayoutTests/platform/glib/fast/tables/021-expected.txt - Updated Test Expectations
* LayoutTests/platform/gtk/fast/table/rowspan-paint-order-vertical-expected.png - Updated Test Expectations
* LayoutTests/platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt - Updated Test Expectations
* LayoutTests/platform/gtk/tables/mozilla/bugs/bug57828-expected.png - Updated Test Expectations
* LayoutTests/platform/gtk/tables/mozilla/bugs/bug78162-expected.png - Updated Test Expectations
* LayoutTests/platform/gtk/tables/mozilla/bugs/bug78162-expected.txt - Updated Test Expectations
* LayoutTests/platform/gtk/tables/mozilla/bugs/bug92143-expected.txt - Updated Test Expectations
* LayoutTests/platform/ios/fast/table/021-expected.txt - Updated Test Expectations
* LayoutTests/platform/ios/fast/table/rowspan-paint-order-vertical-expected.txt - Updated Test Expectations
* LayoutTests/platform/ios/tables/mozilla/bugs/bug57828-expected.txt - Updated Test Expectations
* LayoutTests/platform/ios/tables/mozilla/bugs/bug78162-expected.txt - Updated Tests Expectations
* LayoutTests/platform/ios/tables/mozilla/bugs/bug92143-expected.txt - Updated Tests Expectations
* LayoutTests/platform/mac/fast/table/003-expected.png - Updated Tests Expectations
* LayoutTests/platform/mac/fast/table/003-expected.txt - Updated Test Expectations
* LayoutTests/platform/mac/fast/table/021-expected.png - Updated Test Expectations
* LayoutTests/platform/mac/fast/table/021-expected.txt - Updated Test Expectations
* LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug57828-expected.png - Updated Test Expectations
* LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug57828-expected.txt - Updated Test Expectations
* LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug78162-expected.png - Updated Test Expectations
* LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug78162-expected.txt - Updated Test Expectations
* LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug92143-expected.png - Updated Test Expectations
* LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug92143-expected.txt - Updated Test Expectations
* LayoutTests/platform/mac/fast/table/rowspan-paint-order-vertical-expected.png - Updated Test Expectations
* LayoutTests/platform/mac/fast/table/rowspan-paint-order-vertical-expected.txt - Updated Test Expectations
* LayoutTests/platform/glib/mozilla/bugs/bug57828-expected.txt - Updated Test Expectations

e990887

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	~~🛠 🧪 win~~
	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

Deleting a button element leaves the style inside the button element https://bugs.webkit.org/show_bug.cgi?id=94014 Reviewed by NOBODY (OOPS!). Patch Authored by - Sukolsak Sakshuwong Make the DeleteSelectionCommand save typing style only for formattable nodes according to the HTML Editing specification and match "Blink" behavior. * LayoutTests/editing/deleting/delete-button.html * LayoutTests/editing/deleting/delete-button-expected.txt * Source/WebCore/editing/DelectionSelectionCommand.cpp (WebCore::DeleteSelectionCommand::saveTypingStyleState)

webkit-early-warning-system · 2022-09-07T23:47:20Z

EWS run on previous version of this PR (hash a4948c2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

alanbaradlay

I am not sure what CSSValueWebkitNowrap is used for (WhiteSpace::KHTMLNoWrap) but a simpler fix would be just to call setWhiteSpace(NoWrap) unconditionally in the adjuster.
(It's probably not super relevant anymore, but someone who knows about KHTMLNoWrap should comment on it).

webkit-early-warning-system · 2022-09-08T19:51:03Z

EWS run on previous version of this PR (hash 3763d87)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

Ahmad-S792 · 2022-09-08T20:13:12Z

I am not sure what CSSValueWebkitNowrap is used for (WhiteSpace::KHTMLNoWrap) but a simpler fix would be just to call setWhiteSpace(NoWrap) unconditionally in the adjuster.
(It's probably not super relevant anymore, but someone who knows about KHTMLNoWrap should comment on it).

I can only find two places "CSSValueWebkitNowrap" is present in "CSSPrimitiveValueMappings.h" and IMO we can remove that as well because other is about the use in "HTMLTableCellElement", which I am getting rid of with this patch.

webkit-early-warning-system · 2022-09-09T12:27:10Z

EWS run on previous version of this PR (hash d8d3b97)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-10T13:33:57Z

EWS run on previous version of this PR (hash 895d58a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

… is specified WebKit ignores the nowrap on td nowrap="nowrap", if an absolute width is specified https://bugs.webkit.org/show_bug.cgi?id=183642 Merge - https://chromium.googlesource.com/chromium/src/+/5e6c851254f90f6f495713f7248ffe9a155de413 Previously we only applied it when a <td> element had no fixed-width. This was incorrect behavior and it will align Webkit with Blink and Gecko for Web interop. * Source/WebCore/html/HTMLTableCellElement.cpp (HTMLTableCellElement::hasPresentationalHintsForAttribute) - Update nowrap Attribute to respect CSSValueNowrap rather than CSSValueWebkitNowrap * Source/WebCore/style/StyleAdjuster.cpp (Adjuster:adjust) - Removed logic about td tag only accepting wrap for Fixed Width * LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-nowrap-minimum-width-calculation-expected.txt - Updated Test Expectations * LayoutTests/platform/gtk/fast/table/003-expected.png - Updated Test Expectations * LayoutTests/platform/gtk/fast/table/003-expected.txt - Updated Test Expectations * LayoutTests/platform/gtk/fast/tables/021-expected.png - Updated Test Expectations * LayoutTests/platform/glib/fast/tables/021-expected.txt - Updated Test Expectations * LayoutTests/platform/gtk/fast/table/rowspan-paint-order-vertical-expected.png - Updated Test Expectations * LayoutTests/platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt - Updated Test Expectations * LayoutTests/platform/gtk/tables/mozilla/bugs/bug57828-expected.png - Updated Test Expectations * LayoutTests/platform/gtk/tables/mozilla/bugs/bug78162-expected.png - Updated Test Expectations * LayoutTests/platform/gtk/tables/mozilla/bugs/bug78162-expected.txt - Updated Test Expectations * LayoutTests/platform/gtk/tables/mozilla/bugs/bug92143-expected.txt - Updated Test Expectations * LayoutTests/platform/ios/fast/table/021-expected.txt - Updated Test Expectations * LayoutTests/platform/ios/fast/table/rowspan-paint-order-vertical-expected.txt - Updated Test Expectations * LayoutTests/platform/ios/tables/mozilla/bugs/bug57828-expected.txt - Updated Test Expectations * LayoutTests/platform/ios/tables/mozilla/bugs/bug78162-expected.txt - Updated Tests Expectations * LayoutTests/platform/ios/tables/mozilla/bugs/bug92143-expected.txt - Updated Tests Expectations * LayoutTests/platform/mac/fast/table/003-expected.png - Updated Tests Expectations * LayoutTests/platform/mac/fast/table/003-expected.txt - Updated Test Expectations * LayoutTests/platform/mac/fast/table/021-expected.png - Updated Test Expectations * LayoutTests/platform/mac/fast/table/021-expected.txt - Updated Test Expectations * LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug57828-expected.png - Updated Test Expectations * LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug57828-expected.txt - Updated Test Expectations * LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug78162-expected.png - Updated Test Expectations * LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug78162-expected.txt - Updated Test Expectations * LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug92143-expected.png - Updated Test Expectations * LayoutTests/platform/mac/fast/tables/mozilla/bugs/bug92143-expected.txt - Updated Test Expectations * LayoutTests/platform/mac/fast/table/rowspan-paint-order-vertical-expected.png - Updated Test Expectations * LayoutTests/platform/mac/fast/table/rowspan-paint-order-vertical-expected.txt - Updated Test Expectations * LayoutTests/platform/glib/mozilla/bugs/bug57828-expected.txt - Updated Test Expectations

webkit-early-warning-system · 2022-09-11T12:29:05Z

e990887

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	~~🛠 🧪 win~~
	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

Ahmad-S792 requested review from cdumez and rniwa as code owners September 7, 2022 23:43

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 8, 2022

nt1m requested a review from anttijk September 8, 2022 04:05

rniwa requested a review from alanbaradlay September 8, 2022 04:08

alanbaradlay reviewed Sep 8, 2022

View reviewed changes

Ahmad-S792 force-pushed the fix183642 branch from a4948c2 to 3763d87 Compare September 8, 2022 19:50

Ahmad-S792 force-pushed the fix183642 branch from 3763d87 to d8d3b97 Compare September 9, 2022 12:24

Merge branch 'main' of https://github.com/Ahmad-S792/WebKit

f49ac54

Ahmad-S792 force-pushed the fix183642 branch from d8d3b97 to 895d58a Compare September 10, 2022 13:33

Ahmad-S792 and others added 3 commits September 10, 2022 20:25

Merge branch 'WebKit:main' into main

59e62f5

Merge branch 'WebKit:main' into main

8f4466c

Ahmad-S792 force-pushed the fix183642 branch from 895d58a to e990887 Compare September 11, 2022 12:28

Ahmad-S792 closed this Sep 11, 2022

Ahmad-S792 deleted the fix183642 branch September 17, 2022 07:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WebKit ignores the nowrap on td nowrap="nowrap", if an absolute width is specified #4114

WebKit ignores the nowrap on td nowrap="nowrap", if an absolute width is specified #4114

Ahmad-S792 commented Sep 7, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 7, 2022 •

edited

alanbaradlay left a comment

webkit-early-warning-system commented Sep 8, 2022 •

edited

Ahmad-S792 commented Sep 8, 2022

webkit-early-warning-system commented Sep 9, 2022 •

edited

webkit-early-warning-system commented Sep 10, 2022 •

edited

webkit-early-warning-system commented Sep 11, 2022 •

edited

WebKit ignores the nowrap on td nowrap="nowrap", if an absolute width is specified #4114

WebKit ignores the nowrap on td nowrap="nowrap", if an absolute width is specified #4114

Conversation

Ahmad-S792 commented Sep 7, 2022 • edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 7, 2022 • edited

alanbaradlay left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Sep 8, 2022 • edited

Ahmad-S792 commented Sep 8, 2022

webkit-early-warning-system commented Sep 9, 2022 • edited

webkit-early-warning-system commented Sep 10, 2022 • edited

webkit-early-warning-system commented Sep 11, 2022 • edited

Ahmad-S792 commented Sep 7, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 7, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 9, 2022 •

edited

webkit-early-warning-system commented Sep 10, 2022 •

edited

webkit-early-warning-system commented Sep 11, 2022 •

edited