AX: Support VTT-based extended audio descriptions #4129

eric-carlson · 2022-09-08T15:13:59Z

`c2f7594`

AX: Support VTT-based extended audio descriptions
https://bugs.webkit.org/show_bug.cgi?id=244931
<rdar://99697422>

Reviewed by Jer Noble.

* LayoutTests/media/track/captions-webvtt/captions-extended-descriptions.vtt: Added.
* LayoutTests/media/track/track-description-cue.html:
* LayoutTests/media/track/track-extended-descriptions-expected.txt: Added.
* LayoutTests/media/track/track-extended-descriptions.html: Added.
* LayoutTests/TestExpectations: Feature is Cocoa-specific so far, skip test globally.
* LayoutTests/platform/ios/TestExpectations: Enable test on iOS.
* LayoutTests/platform/mac/TestExpectations: Enable test on macOS.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: Add 'ExtendedAudioDescriptionsEnabled'
setting.

* Source/WebCore/Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::setPlatformSynthesizer): Take a Ref<> synthesizer instead of a
unique_ptr.
(WebCore::SpeechSynthesis::ensurePlatformSpeechSynthesizer): Use PlatformSpeechSynthesizer::create.
* Source/WebCore/Modules/speech/SpeechSynthesis.h:

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::convertEnumerationToString): Added.
(WebCore::HTMLMediaElement::unregisterWithDocument): Cancel speech, clear synthesize.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Cleanup for readability.
(WebCore::HTMLMediaElement::setSpeechSynthesisState): Update for extended descriptions.
(WebCore::HTMLMediaElement::speakCueText): Call cue.prepareToSpeak as we don't always want
a cue to begin speaking immediately.
(WebCore::HTMLMediaElement::pauseSpeakingCueText): Support completing an extended description.
(WebCore::HTMLMediaElement::resumeSpeakingCueText): Ditto.
(WebCore::HTMLMediaElement::pausePlaybackForExtendedTextDescription): New, pause playback
to allow an extended description to complete.
(WebCore::HTMLMediaElement::speechSynthesis): Have the media element own the synthesizer
since the logic for managing it is here.
(WebCore::HTMLMediaElement::executeCueEnterOrExitActionForTime): Support extended descriptions.
(WebCore::HTMLMediaElement::addTextTrack): Set m_userPrefersExtendedDescriptions.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Use m_userPrefersTextDescriptions.
(WebCore::HTMLMediaElement::updatePlayState): Pause and resume speaking here, not in `playPlayer`
and `pausePlayer`.
(WebCore::HTMLMediaElement::playPlayer): Ditto.
(WebCore::HTMLMediaElement::pausePlayer): Ditto.
(WebCore::HTMLMediaElement::captionPreferencesChanged): set m_userPrefersExtendedDescriptions.
(WebCore::HTMLMediaElement::executeCueEnterOrLeaveAction): Deleted.
* Source/WebCore/html/HTMLMediaElement.h:
(WTF::LogArgument<WebCore::HTMLMediaElement::SpeechSynthesisState>::toString):

* Source/WebCore/html/track/TextTrack.cpp:
(WebCore::TextTrack::speechSynthesis): Deleted.
* Source/WebCore/html/track/TextTrack.h:

* Source/WebCore/html/track/TextTrackCue.h:
(WebCore::TextTrackCue::prepareToSpeak): Renamed from `speak`.
(WebCore::TextTrackCue::beginSpeaking): Added.
(WebCore::TextTrackCue::pauseSpeaking): Added.
(WebCore::TextTrackCue::cancelSpeaking): Added.
(WebCore::TextTrackCue::speak): Deleted.

* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::mapVideoRateToSpeechRate): Convert playback rate to web speech rate.
(WebCore::VTTCue::prepareToSpeak): Call completion handler when there is nothing to speak
or when the track is null. Stash `speechSynthesis` for future use.
(WebCore::VTTCue::beginSpeaking): Begin or resume speaking.
(WebCore::VTTCue::pauseSpeaking):
(WebCore::VTTCue::cancelSpeaking):
(WebCore::VTTCue::speak): Deleted.
* Source/WebCore/html/track/VTTCue.h:

* Source/WebCore/page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::userPrefersTextDescriptions const): Consider setting for
extended descriptions.
* Source/WebCore/platform/PlatformSpeechSynthesizer.h: Make refcounted.

* Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]): `client()` is a ref, not a pointer.
(-[WebSpeechSynthesisWrapper speechSynthesizer:didStartSpeechUtterance:]): Ditto.
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeechUtterance:]): Ditto.
(-[WebSpeechSynthesisWrapper speechSynthesizer:didPauseSpeechUtterance:]): Ditto.
(-[WebSpeechSynthesisWrapper speechSynthesizer:didContinueSpeechUtterance:]): Ditto.
(-[WebSpeechSynthesisWrapper speechSynthesizer:didCancelSpeechUtterance:]): Ditto.
(-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakRangeOfSpeechString:utterance:]): Ditto.
(WebCore::PlatformSpeechSynthesizer::create): Client can never be null so take ref, not a pointer.
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):

* Source/WebCore/platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::create): Client can never be null so take ref, not a pointer.
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished): `client()` is a ref, not a pointer.
(WebCore::PlatformSpeechSynthesizerMock::speak): Ditto. Use configurable utterance duration.
(WebCore::PlatformSpeechSynthesizerMock::cancel): Ditto.
(WebCore::PlatformSpeechSynthesizerMock::pause): Ditto. Null-check `m_utterance`.
(WebCore::PlatformSpeechSynthesizerMock::resume): Ditto.
* Source/WebCore/platform/mock/PlatformSpeechSynthesizerMock.h:
(WebCore::PlatformSpeechSynthesizerMock::setUtteranceDuration):

* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::enableMockSpeechSynthesizer):
(WebCore::Internals::enableMockSpeechSynthesizerForMediaElement):
(WebCore::Internals::setSpeechUtteranceDuration):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetSpeechSynthesizer): PlatformSpeechSynthesizer is a Ref, not
a unique_ptr.
(WebKit::WebPageProxy::speechSynthesisData): Ditto.
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/254502@main

ebfd896

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-08T15:14:59Z

EWS run on previous version of this PR (hash ea057dc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk1~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-08T16:24:36Z

EWS run on previous version of this PR (hash 9778d06)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	❌ 🛠 gtk	~~🛠 wincairo~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk1~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-08T18:25:43Z

EWS run on previous version of this PR (hash 2278150)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-08T23:08:32Z

EWS run on previous version of this PR (hash 6c18987)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-12T16:47:07Z

EWS run on previous version of this PR (hash 8f54ca7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

jernoble · 2022-09-13T19:56:00Z

Source/WebCore/Modules/speech/SpeechSynthesis.cpp

@@ -74,9 +74,9 @@ SpeechSynthesis::SpeechSynthesis(ScriptExecutionContext& context)

 SpeechSynthesis::~SpeechSynthesis() = default;

-void SpeechSynthesis::setPlatformSynthesizer(std::unique_ptr<PlatformSpeechSynthesizer> synthesizer)
+void SpeechSynthesis::setPlatformSynthesizer(Ref<PlatformSpeechSynthesizer> synthesizer)


This should take a Ref<PlatformSpeechSynthesizer>&&.

jernoble · 2022-09-13T19:56:46Z

Source/WebCore/Modules/speech/SpeechSynthesis.cpp

 {
-    m_platformSpeechSynthesizer = WTFMove(synthesizer);
+    m_platformSpeechSynthesizer = synthesizer.ptr();


...and then you can get rid of this.

webkit-early-warning-system · 2022-09-14T17:56:10Z

ebfd896

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

https://bugs.webkit.org/show_bug.cgi?id=244931 <rdar://99697422> Reviewed by Jer Noble. * LayoutTests/media/track/captions-webvtt/captions-extended-descriptions.vtt: Added. * LayoutTests/media/track/track-description-cue.html: * LayoutTests/media/track/track-extended-descriptions-expected.txt: Added. * LayoutTests/media/track/track-extended-descriptions.html: Added. * LayoutTests/TestExpectations: Feature is Cocoa-specific so far, skip test globally. * LayoutTests/platform/ios/TestExpectations: Enable test on iOS. * LayoutTests/platform/mac/TestExpectations: Enable test on macOS. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: Add 'ExtendedAudioDescriptionsEnabled' setting. * Source/WebCore/Modules/speech/SpeechSynthesis.cpp: (WebCore::SpeechSynthesis::setPlatformSynthesizer): Take a Ref<> synthesizer instead of a unique_ptr. (WebCore::SpeechSynthesis::ensurePlatformSpeechSynthesizer): Use PlatformSpeechSynthesizer::create. * Source/WebCore/Modules/speech/SpeechSynthesis.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::convertEnumerationToString): Added. (WebCore::HTMLMediaElement::unregisterWithDocument): Cancel speech, clear synthesize. (WebCore::HTMLMediaElement::updateActiveTextTrackCues): Cleanup for readability. (WebCore::HTMLMediaElement::setSpeechSynthesisState): Update for extended descriptions. (WebCore::HTMLMediaElement::speakCueText): Call cue.prepareToSpeak as we don't always want a cue to begin speaking immediately. (WebCore::HTMLMediaElement::pauseSpeakingCueText): Support completing an extended description. (WebCore::HTMLMediaElement::resumeSpeakingCueText): Ditto. (WebCore::HTMLMediaElement::pausePlaybackForExtendedTextDescription): New, pause playback to allow an extended description to complete. (WebCore::HTMLMediaElement::speechSynthesis): Have the media element own the synthesizer since the logic for managing it is here. (WebCore::HTMLMediaElement::executeCueEnterOrExitActionForTime): Support extended descriptions. (WebCore::HTMLMediaElement::addTextTrack): Set m_userPrefersExtendedDescriptions. (WebCore::HTMLMediaElement::configureTextTrackGroup): Use m_userPrefersTextDescriptions. (WebCore::HTMLMediaElement::updatePlayState): Pause and resume speaking here, not in `playPlayer` and `pausePlayer`. (WebCore::HTMLMediaElement::playPlayer): Ditto. (WebCore::HTMLMediaElement::pausePlayer): Ditto. (WebCore::HTMLMediaElement::captionPreferencesChanged): set m_userPrefersExtendedDescriptions. (WebCore::HTMLMediaElement::executeCueEnterOrLeaveAction): Deleted. * Source/WebCore/html/HTMLMediaElement.h: (WTF::LogArgument<WebCore::HTMLMediaElement::SpeechSynthesisState>::toString): * Source/WebCore/html/track/TextTrack.cpp: (WebCore::TextTrack::speechSynthesis): Deleted. * Source/WebCore/html/track/TextTrack.h: * Source/WebCore/html/track/TextTrackCue.h: (WebCore::TextTrackCue::prepareToSpeak): Renamed from `speak`. (WebCore::TextTrackCue::beginSpeaking): Added. (WebCore::TextTrackCue::pauseSpeaking): Added. (WebCore::TextTrackCue::cancelSpeaking): Added. (WebCore::TextTrackCue::speak): Deleted. * Source/WebCore/html/track/VTTCue.cpp: (WebCore::mapVideoRateToSpeechRate): Convert playback rate to web speech rate. (WebCore::VTTCue::prepareToSpeak): Call completion handler when there is nothing to speak or when the track is null. Stash `speechSynthesis` for future use. (WebCore::VTTCue::beginSpeaking): Begin or resume speaking. (WebCore::VTTCue::pauseSpeaking): (WebCore::VTTCue::cancelSpeaking): (WebCore::VTTCue::speak): Deleted. * Source/WebCore/html/track/VTTCue.h: * Source/WebCore/page/CaptionUserPreferences.cpp: (WebCore::CaptionUserPreferences::userPrefersTextDescriptions const): Consider setting for extended descriptions. * Source/WebCore/platform/PlatformSpeechSynthesizer.h: Make refcounted. * Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm: (-[WebSpeechSynthesisWrapper speakUtterance:]): `client()` is a ref, not a pointer. (-[WebSpeechSynthesisWrapper speechSynthesizer:didStartSpeechUtterance:]): Ditto. (-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeechUtterance:]): Ditto. (-[WebSpeechSynthesisWrapper speechSynthesizer:didPauseSpeechUtterance:]): Ditto. (-[WebSpeechSynthesisWrapper speechSynthesizer:didContinueSpeechUtterance:]): Ditto. (-[WebSpeechSynthesisWrapper speechSynthesizer:didCancelSpeechUtterance:]): Ditto. (-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakRangeOfSpeechString:utterance:]): Ditto. (WebCore::PlatformSpeechSynthesizer::create): Client can never be null so take ref, not a pointer. (WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer): * Source/WebCore/platform/mock/PlatformSpeechSynthesizerMock.cpp: (WebCore::PlatformSpeechSynthesizerMock::create): Client can never be null so take ref, not a pointer. (WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock): (WebCore::PlatformSpeechSynthesizerMock::speakingFinished): `client()` is a ref, not a pointer. (WebCore::PlatformSpeechSynthesizerMock::speak): Ditto. Use configurable utterance duration. (WebCore::PlatformSpeechSynthesizerMock::cancel): Ditto. (WebCore::PlatformSpeechSynthesizerMock::pause): Ditto. Null-check `m_utterance`. (WebCore::PlatformSpeechSynthesizerMock::resume): Ditto. * Source/WebCore/platform/mock/PlatformSpeechSynthesizerMock.h: (WebCore::PlatformSpeechSynthesizerMock::setUtteranceDuration): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::enableMockSpeechSynthesizer): (WebCore::Internals::enableMockSpeechSynthesizerForMediaElement): (WebCore::Internals::setSpeechUtteranceDuration): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::resetSpeechSynthesizer): PlatformSpeechSynthesizer is a Ref, not a unique_ptr. (WebKit::WebPageProxy::speechSynthesisData): Ditto. * Source/WebKit/UIProcess/WebPageProxy.h: Canonical link: https://commits.webkit.org/254502@main

webkit-commit-queue · 2022-09-15T02:06:46Z

Committed 254502@main (c2f7594): https://commits.webkit.org/254502@main

Reviewed commits have been landed. Closing PR #4129 and removing active labels.

eric-carlson requested review from cdumez and rniwa as code owners September 8, 2022 15:13

eric-carlson self-assigned this Sep 8, 2022

eric-carlson added Media Bugs related to the HTML 5 Media elements. WebKit Nightly Build labels Sep 8, 2022

eric-carlson requested a review from jernoble September 8, 2022 15:14

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 8, 2022

eric-carlson force-pushed the extended-text-descriptions branch from ea057dc to 9778d06 Compare September 8, 2022 16:24

eric-carlson force-pushed the extended-text-descriptions branch from 9778d06 to 2278150 Compare September 8, 2022 18:22

eric-carlson force-pushed the extended-text-descriptions branch from 2278150 to 6c18987 Compare September 8, 2022 23:06

eric-carlson removed the merging-blocked Applied to prevent a change from being merged label Sep 8, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 9, 2022

eric-carlson force-pushed the extended-text-descriptions branch from 6c18987 to 8f54ca7 Compare September 12, 2022 16:43

eric-carlson removed the merging-blocked Applied to prevent a change from being merged label Sep 12, 2022

jernoble approved these changes Sep 13, 2022

View reviewed changes

eric-carlson force-pushed the extended-text-descriptions branch from 8f54ca7 to ebfd896 Compare September 14, 2022 17:56

eric-carlson added the merge-queue Applied to send a pull request to merge-queue label Sep 15, 2022

webkit-early-warning-system force-pushed the extended-text-descriptions branch from ebfd896 to c2f7594 Compare September 15, 2022 02:06

webkit-early-warning-system merged commit c2f7594 into WebKit:main Sep 15, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AX: Support VTT-based extended audio descriptions #4129

AX: Support VTT-based extended audio descriptions #4129

eric-carlson commented Sep 8, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 12, 2022 •

edited

jernoble Sep 13, 2022

jernoble Sep 13, 2022

webkit-early-warning-system commented Sep 14, 2022 •

edited

webkit-commit-queue commented Sep 15, 2022

AX: Support VTT-based extended audio descriptions #4129

AX: Support VTT-based extended audio descriptions #4129

Conversation

eric-carlson commented Sep 8, 2022 • edited by webkit-early-warning-system

c2f7594

webkit-early-warning-system commented Sep 8, 2022 • edited

webkit-early-warning-system commented Sep 8, 2022 • edited

webkit-early-warning-system commented Sep 8, 2022 • edited

webkit-early-warning-system commented Sep 8, 2022 • edited

webkit-early-warning-system commented Sep 12, 2022 • edited

jernoble Sep 13, 2022

Choose a reason for hiding this comment

jernoble Sep 13, 2022

Choose a reason for hiding this comment

webkit-early-warning-system commented Sep 14, 2022 • edited

webkit-commit-queue commented Sep 15, 2022

eric-carlson commented Sep 8, 2022 •

edited by webkit-early-warning-system

`c2f7594`

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 8, 2022 •

edited

webkit-early-warning-system commented Sep 12, 2022 •

edited

webkit-early-warning-system commented Sep 14, 2022 •

edited