Add support for COOP navigation violation reporting #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
WebCore Misc.
|
EWS run on previous version of this PR (hash 8fb3261)
|
rniwa
approved these changes
Sep 8, 2022
brentfulgham
reviewed
Sep 8, 2022
| @@ -1,4 +1,4 @@ | |||
|
|
|||
| FAIL coop reporting test A test with both COOP and COOP report only setup to CROSS_ORIGIN with same-origin-allow-popups; report-to="coop-popup-report-endpoint", require-corp, same-origin; report-to="coop-popup-report-only-endpoint", require-corp promise_test: Unhandled rejection with value: "No report matched the expected report for endpoint: coop-report-endpoint, expected report: {\"body\":{\"disposition\":\"enforce\",\"effectivePolicy\":\"same-origin-allow-popups\",\"nextResponseURL\":\"/uuid=(uuid)$/\",\"type\":\"navigation-from-response\"},\"url\":\"https://localhost:9443/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html\",\"type\":\"coop\"}, within available reports: []" | |||
| PASS coop reporting test A test with both COOP and COOP report only setup to CROSS_ORIGIN with same-origin-allow-popups; report-to="coop-popup-report-endpoint", require-corp, same-origin; report-to="coop-popup-report-only-endpoint", require-corp | |||
brentfulgham
approved these changes
Sep 8, 2022
Source/WebCore/loader/PingLoader.cpp
Outdated
| @@ -186,7 +191,7 @@ void PingLoader::sendViolationReport(Frame& frame, const URL& reportURL, Ref<For | |||
|
|
|||
| HTTPHeaderMap originalRequestHeader = request.httpHeaderFields(); | |||
|
|
|||
| if (reportType != ViolationReportType::StandardReportingAPIViolation && reportType != ViolationReportType::Test) | |||
| if (reportType != ViolationReportType::StandardReportingAPIViolation && reportType != ViolationReportType::Test && reportType != ViolationReportType::CrossOriginOpenerPolicy) | |||
There was a problem hiding this comment.
Maybe we should check check for equality with the CSP ViolationReportType, unless we have other types that need this behavior.
Source/WebCore/loader/PingLoader.cpp
Outdated
| @@ -215,7 +220,7 @@ void PingLoader::startPingLoad(Frame& frame, ResourceRequest& request, HTTPHeade | |||
| options.cache = FetchOptions::Cache::NoCache; | |||
|
|
|||
| // https://www.w3.org/TR/reporting/#try-delivery | |||
| if (violationReportType == ViolationReportType::StandardReportingAPIViolation || violationReportType == ViolationReportType::Test) { | |||
| if (violationReportType == ViolationReportType::StandardReportingAPIViolation || violationReportType == ViolationReportType::Test || violationReportType == ViolationReportType::CrossOriginOpenerPolicy) { | |||
cdumez
force-pushed
the
coop_reporting_support
branch
from
8fb3261
to
7c310c1
Compare
|
EWS run on previous version of this PR (hash 7c310c1) |
webkit-ews-buildbot
added
merging-blocked
cdumez
force-pushed
the
coop_reporting_support
branch
from
7c310c1
to
4786e18
Compare
https://bugs.webkit.org/show_bug.cgi?id=244936 Reviewed by Ryosuke Niwa and Brent Fulgham. Add support for COOP navigation violation reporting: - https://html.spec.whatwg.org/multipage/origin.html#coop-violation-navigation-to - https://html.spec.whatwg.org/multipage/origin.html#coop-violation-navigation-from * LayoutTests/TestExpectations: Unskip navigation-reporting folder now that the feature is implemented. * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-from-unsafe-none.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-same-origin-report-to.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-same-origin.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-popup.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-popup-same-origin-allow-popups-report-to.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-popup-same-origin-coep-report-to.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-popup-same-origin-report-to.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-popup-same-origin.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-popup-unsafe-none-report-to.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-redirect-with-same-origin-allow-popups.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-redirect-with-same-origin-allow-popups.https.html: Rebaseline tests that are now passing and merge the following upstream fix: - web-platform-tests/wpt#35824 * Source/WebCore/Modules/reporting/ReportingClient.h: * Source/WebCore/Modules/reporting/ViolationReportType.h: * Source/WebCore/dom/Document.cpp: (WebCore::Document::httpUserAgent const): * Source/WebCore/dom/Document.h: * Source/WebCore/loader/CrossOriginOpenerPolicy.cpp: (WebCore::crossOriginOpenerPolicyValueToEffectivePolicyString): (WebCore::createViolationReportObject): (WebCore::sendViolationReportWhenNavigatingToCOOPResponse): (WebCore::sendViolationReportWhenNavigatingAwayFromCOOPResponse): (WebCore::enforceResponseCrossOriginOpenerPolicy): (WebCore::doCrossOriginOpenerHandlingOfResponse): * Source/WebCore/loader/CrossOriginOpenerPolicy.h: * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::doCrossOriginOpenerHandlingOfResponse): * Source/WebCore/loader/PingLoader.cpp: (WebCore::PingLoader::sendViolationReport): (WebCore::PingLoader::startPingLoad): * Source/WebCore/workers/WorkerGlobalScope.h: * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions): (WebKit::NetworkResourceLoader::doCrossOriginOpenerHandlingOfResponse): (WebKit::NetworkResourceLoader::didReceiveResponse): (WebKit::NetworkResourceLoader::initializeReportingEndpoints): (WebKit::NetworkResourceLoader::didRetrieveCacheEntry): * Source/WebKit/NetworkProcess/NetworkResourceLoader.h: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<RefPtr<WebCore::ReportBody>>::encode): (IPC::ArgumentCoder<RefPtr<WebCore::ReportBody>>::decode): Canonical link: https://commits.webkit.org/254291@main
webkit-early-warning-system
force-pushed
the
coop_reporting_support
branch
from
4786e18
to
67d5c3c
Compare
|
Committed 254291@main (67d5c3c): https://commits.webkit.org/254291@main Reviewed commits have been landed. Closing PR #4133 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
67d5c3c
4786e18
🧪 mac-wk1🧪 mac-AS-debug-wk2