[LBSE] Not all 'outermost' <svg> elements enforce a stacking context #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🛠 watch
nikolaszimmermann
added
SVG
nikolaszimmermann
added
the
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=244965 Reviewed by Rob Buis. Add missing condition in Style::Adjuster::adjustSVGElementStyle() to enforce a stacking context if the element that receives the style is an outermost <svg> element (or acts as such). It is mentioned in the SVG2 spec note just a few lines above, but not implemented yet. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/css/text-shadow-multiple-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/custom/image-parent-translation-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/custom/second-inline-text-expected.txt: * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjustSVGElementStyle): Canonical link: https://commits.webkit.org/254314@main
webkit-early-warning-system
force-pushed
the
eng/LBSE-Not-all-outermost-svg-elements-enforce-a-stacking-context
branch
from
abb2f35
to
a57723e
Compare
|
Committed 254314@main (a57723e): https://commits.webkit.org/254314@main Reviewed commits have been landed. Closing PR #4157 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
nikolaszimmermann
deleted the
eng/LBSE-Not-all-outermost-svg-elements-enforce-a-stacking-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a57723e
abb2f35
🛠 🧪 win🧪 mac-wk1🧪 mac-AS-debug-wk2