Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a HashSet instead of a std::unique_ptr<HashSet> for StyleRareNonInheritedData.customPaintWatchedProperties #428

Merged
merged 0 commits into from Apr 28, 2022
Merged

Use a HashSet instead of a std::unique_ptr<HashSet> for StyleRareNonInheritedData.customPaintWatchedProperties #428

merged 0 commits into from Apr 28, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 28, 2022 •
edited by webkit-early-warning-system

599eabc

Use a HashSet instead of a std::unique_ptr<HashSet > for StyleRareNonInheritedData.customPaintWatchedProperties
https://bugs.webkit.org/show_bug.cgi?id=239863

Reviewed by Yusuke Suzuki.

Use a HashSet instead of a std::unique_ptr<HashSet > for StyleRareNonInheritedData.customPaintWatchedProperties.
A HashSet is already essentially a pointer, no need for the extra dereferencing.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::addCustomPaintWatchProperty):
(WebCore::changedCustomPaintWatchedProperty):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:

Canonical link: https://commits.webkit.org/250105@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@cdumez cdumez self-assigned this Apr 28, 2022
@cdumez cdumez added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels Apr 28, 2022
Constellation
Constellation approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, yes, this is better.

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 28, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 599eabc into WebKit:main Apr 28, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r293596 (250105@main): https://commits.webkit.org/250105@main

Reviewed commits have been landed. Closing PR #428 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@cdumez cdumez

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
3 participants
@cdumez @webkit-early-warning-system @Constellation