Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert [253685@main] Incorrect behavior of "cursor: auto" over links #4348

Conversation

vitorroriz
Copy link
Contributor

@vitorroriz vitorroriz commented Sep 14, 2022

2ef8bf0

Revert [253685@main] Incorrect behavior of "cursor: auto" over links
https://bugs.webkit.org/show_bug.cgi?id=173909
rdar://33054544

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/mouse-cursor-imagemap-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/no-help-cursor-on-links.historical-expected.txt:
* Source/WebCore/css/html.css:
(a:any-link):
(a:any-link:read-write): Deleted.
(area:any-link): Deleted.
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
* Source/WebCore/page/EventHandler.h:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::positionInformation):

Canonical link: https://commits.webkit.org/254480@main

fe30bf2

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim   πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2   πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios   πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@vitorroriz vitorroriz self-assigned this Sep 14, 2022
@vitorroriz vitorroriz added CSS Cascading Style Sheets implementation WebKit Nightly Build labels Sep 14, 2022
@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Sep 14, 2022
https://bugs.webkit.org/show_bug.cgi?id=173909
rdar://33054544

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/mouse-cursor-imagemap-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/no-help-cursor-on-links.historical-expected.txt:
* Source/WebCore/css/html.css:
(a:any-link):
(a:any-link:read-write): Deleted.
(area:any-link): Deleted.
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
* Source/WebCore/page/EventHandler.h:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::positionInformation):

Canonical link: https://commits.webkit.org/254480@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/revert-Incorrect-behavior-of-cursor-auto-over-links branch from fe30bf2 to 2ef8bf0 Compare September 14, 2022 16:54
@webkit-commit-queue
Copy link
Collaborator

Committed 254480@main (2ef8bf0): https://commits.webkit.org/254480@main

Reviewed commits have been landed. Closing PR #4348 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 2ef8bf0 into WebKit:main Sep 14, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
4 participants