Implement nested Dedicated Workers #4349

cdumez · 2022-09-14T15:46:03Z

`48880e3`

Implement nested Dedicated Workers
https://bugs.webkit.org/show_bug.cgi?id=22723
<rdar://6425810>

Reviewed by Darin Adler.

Add support for nested dedicated workers. Blink and Gecko already support this.

Also fix an issue where ScriptExecutionContext were added too early to the ScriptExecutionContextMap.
This was marking calls to postTaskTo() unsafe since it would call the virtual postTask() function
on a ScriptExecutionContext that had potentially not finished construction. This was causing flaky
test crashes.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-classic.http-rp/opt-in/worker-classic.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-classic.http-rp/opt-in/worker-module.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-classic.http-rp/unset/worker-classic.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-classic.http-rp/unset/worker-module.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-module.http-rp/opt-in/worker-classic.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-module.http-rp/opt-in/worker-module.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-module.http-rp/unset/worker-classic.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-module.http-rp/unset/worker-module.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/upgrade-insecure-requests/gen/worker-classic.http-rp/upgrade/worker-classic.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/upgrade-insecure-requests/gen/worker-classic.http-rp/upgrade/worker-module.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/upgrade-insecure-requests/gen/worker-module.http-rp/upgrade/worker-classic.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/upgrade-insecure-requests/gen/worker-module.http-rp/upgrade/worker-module.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/wasm/serialization/module/nested-worker-success.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-locks/query.tentative.https.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webmessaging/MessageEvent-trusted.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webmessaging/message-channels/worker-post-after-close.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webmessaging/message-channels/worker.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/websockets/Create-on-worker-shutdown.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/worker-in-worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/expected-self-properties.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_close_from_parent_worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_close_self.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_importScripts.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_sync_xhr.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_terminate_from_document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/workers/semantics/multiple-workers/exposure.any.worker-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.worker-expected.txt: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt: Added.
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:
* Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.cpp:
(WebCore::AudioWorkletMessagingProxy::loaderContextIdentifier const):
* Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.h:
* Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::~DedicatedWorkerGlobalScope):
* Source/WebCore/workers/Worker.cpp:
(WebCore::Worker::networkStateChanged):
(WebCore::Worker::Worker):
(WebCore::Worker::create):
(WebCore::Worker::~Worker):
(WebCore::Worker::forEachWorker):
(WebCore::Worker::notifyNetworkStateChange): Deleted.
(WebCore::Worker::byIdentifier): Deleted.
* Source/WebCore/workers/Worker.h:
* Source/WebCore/workers/Worker.idl:
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
* Source/WebCore/workers/WorkerLoaderProxy.h:
* Source/WebCore/workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::loaderContextIdentifier const):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::createCacheStorageConnection):
(WebCore::WorkerMessagingProxy::storageConnection):
(WebCore::WorkerMessagingProxy::createRTCDataChannelRemoteHandlerConnection):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerObjectDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyedInternal):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
* Source/WebCore/workers/WorkerMessagingProxy.h:
* Source/WebCore/workers/WorkerOrWorkletThread.cpp:
(WebCore::WorkerOrWorkletThread::workerOrWorkletThread):
(WebCore::WorkerOrWorkletThread::destroyWorkerGlobalScope):
(WebCore::WorkerOrWorkletThread::stop):
(WebCore::WorkerOrWorkletThread::addChildThread):
(WebCore::WorkerOrWorkletThread::removeChildThread):
* Source/WebCore/workers/WorkerOrWorkletThread.h:
* Source/WebCore/workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::notifyClientsOfControllerChange):
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope):
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::loaderContextIdentifier const):
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h:
* Source/WebCore/workers/shared/SharedWorkerGlobalScope.cpp:
(WebCore::SharedWorkerGlobalScope::~SharedWorkerGlobalScope):
* Source/WebCore/workers/shared/SharedWorkerGlobalScope.h:
* Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:
(WebCore::SharedWorkerThreadProxy::loaderContextIdentifier const):
* Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:

Canonical link: https://commits.webkit.org/254597@main

feb5352

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	~~🛠 mac-debug~~	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-14T15:46:10Z

EWS run on previous version of this PR (hash 60a9a12)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-14T23:05:30Z

EWS run on previous version of this PR (hash 8d23da1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	⏳ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-15T02:23:24Z

EWS run on previous version of this PR (hash d0f9673)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	⏳ 🧪 api-mac	~~🧪 api-gtk~~
	✅ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-15T05:37:45Z

EWS run on previous version of this PR (hash bd6c90f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-15T15:30:44Z

EWS run on previous version of this PR (hash 0aeb36b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-16T04:00:29Z

EWS run on previous version of this PR (hash 57882f4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-17T16:21:14Z

EWS run on previous version of this PR (hash 581582d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	✅ 🛠 wpe	~~🛠 🧪 win~~
	~~🛠 ios-sim~~	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🛠 mac-AS-debug~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 api-mac~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	❌ 🛠 tv	~~🧪 mac-wk1~~	⏳ 🛠 jsc-armv7
	~~🛠 tv-sim~~	~~🧪 mac-wk2~~	⏳ 🧪 jsc-armv7-tests
	❌ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	~~🛠 jsc-mips~~
	❌ 🛠 watch-sim	~~🧪 mac-wk2-stress~~	~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2022-09-17T16:42:33Z

EWS run on previous version of this PR (hash 278f75c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	~~🛠 🧪 win~~
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 api-mac	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-17T17:03:59Z

EWS run on previous version of this PR (hash 7acc4b6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-17T22:19:38Z

feb5352

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	~~🛠 mac-debug~~	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

darinadler

We want a quick obvious failure if someone forgets to do addToContexMap or removeFromContexMap in a derived class. Might be worth thinking about how to accomplish that. For removeFromContextMap we could change things so it’s done by the deref function’s destroy code rather than by the destructor, and then implementers of derived classes can’t forget.

cdumez · 2022-09-17T23:49:02Z

We want a quick obvious failure if someone forgets to do addToContexMap or removeFromContexMap in a derived class. Might be worth thinking about how to accomplish that. For removeFromContextMap we could change things so it’s done by the deref function’s destroy code rather than by the destructor, and then implementers of derived classes can’t forget.

The good news is that if we forget to call addToContextsMap(), then the destructor will hit an assertion. This is how I caught all the missing cases. Not sure how to catch the issue earlier.

I agree with you that the deref() function should call removeFromContextsMap().
It would be safer to call removeFromContextsMap() before destruction since we're not supposed to make virtual function calls while running the destructor. Sadly, it is not as trivial as it looks because the ref counting of ScriptExecutionContext is delegated to its subclasses. The reason for that is that Document is one of the subclasses and Document has very special refcounting (since it is a Node). We definitely don't want to slow down Node ref-counting by adding a check in its deref().

https://bugs.webkit.org/show_bug.cgi?id=22723 <rdar://6425810> Reviewed by Darin Adler. Add support for nested dedicated workers. Blink and Gecko already support this. Also fix an issue where ScriptExecutionContext were added too early to the ScriptExecutionContextMap. This was marking calls to postTaskTo() unsafe since it would call the virtual postTask() function on a ScriptExecutionContext that had potentially not finished construction. This was causing flaky test crashes. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-classic.http-rp/opt-in/worker-classic.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-classic.http-rp/opt-in/worker-module.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-classic.http-rp/unset/worker-classic.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-classic.http-rp/unset/worker-module.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-module.http-rp/opt-in/worker-classic.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-module.http-rp/opt-in/worker-module.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-module.http-rp/unset/worker-classic.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mixed-content/gen/worker-module.http-rp/unset/worker-module.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/upgrade-insecure-requests/gen/worker-classic.http-rp/upgrade/worker-classic.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/upgrade-insecure-requests/gen/worker-classic.http-rp/upgrade/worker-module.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/upgrade-insecure-requests/gen/worker-module.http-rp/upgrade/worker-classic.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/upgrade-insecure-requests/gen/worker-module.http-rp/upgrade/worker-module.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/wasm/serialization/module/nested-worker-success.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-locks/query.tentative.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webmessaging/MessageEvent-trusted.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webmessaging/message-channels/worker-post-after-close.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webmessaging/message-channels/worker.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/websockets/Create-on-worker-shutdown.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/worker-in-worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/expected-self-properties.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_close_from_parent_worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_close_self.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_importScripts.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_sync_xhr.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/nested_worker_terminate_from_document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/semantics/multiple-workers/exposure.any.worker-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.worker-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt: Added. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: * Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.cpp: (WebCore::AudioWorkletMessagingProxy::loaderContextIdentifier const): * Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.h: * Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp: (WebCore::DedicatedWorkerGlobalScope::~DedicatedWorkerGlobalScope): * Source/WebCore/workers/Worker.cpp: (WebCore::Worker::networkStateChanged): (WebCore::Worker::Worker): (WebCore::Worker::create): (WebCore::Worker::~Worker): (WebCore::Worker::forEachWorker): (WebCore::Worker::notifyNetworkStateChange): Deleted. (WebCore::Worker::byIdentifier): Deleted. * Source/WebCore/workers/Worker.h: * Source/WebCore/workers/Worker.idl: * Source/WebCore/workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::~WorkerGlobalScope): * Source/WebCore/workers/WorkerLoaderProxy.h: * Source/WebCore/workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): (WebCore::WorkerMessagingProxy::~WorkerMessagingProxy): (WebCore::WorkerMessagingProxy::startWorkerGlobalScope): (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postTaskToWorkerObject): (WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope): (WebCore::WorkerMessagingProxy::loaderContextIdentifier const): (WebCore::WorkerMessagingProxy::postTaskToLoader): (WebCore::WorkerMessagingProxy::createCacheStorageConnection): (WebCore::WorkerMessagingProxy::storageConnection): (WebCore::WorkerMessagingProxy::createRTCDataChannelRemoteHandlerConnection): (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject): (WebCore::WorkerMessagingProxy::workerObjectDestroyed): (WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed): (WebCore::WorkerMessagingProxy::workerGlobalScopeClosed): (WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyedInternal): (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject): (WebCore::WorkerMessagingProxy::reportPendingActivity): * Source/WebCore/workers/WorkerMessagingProxy.h: * Source/WebCore/workers/WorkerOrWorkletThread.cpp: (WebCore::WorkerOrWorkletThread::workerOrWorkletThread): (WebCore::WorkerOrWorkletThread::destroyWorkerGlobalScope): (WebCore::WorkerOrWorkletThread::stop): (WebCore::WorkerOrWorkletThread::addChildThread): (WebCore::WorkerOrWorkletThread::removeChildThread): * Source/WebCore/workers/WorkerOrWorkletThread.h: * Source/WebCore/workers/service/SWClientConnection.cpp: (WebCore::SWClientConnection::postMessageToServiceWorkerClient): (WebCore::SWClientConnection::notifyClientsOfControllerChange): * Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp: (WebCore::ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope): * Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp: (WebCore::ServiceWorkerThreadProxy::loaderContextIdentifier const): * Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h: * Source/WebCore/workers/shared/SharedWorkerGlobalScope.cpp: (WebCore::SharedWorkerGlobalScope::~SharedWorkerGlobalScope): * Source/WebCore/workers/shared/SharedWorkerGlobalScope.h: * Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp: (WebCore::SharedWorkerThreadProxy::loaderContextIdentifier const): * Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h: Canonical link: https://commits.webkit.org/254597@main

webkit-commit-queue · 2022-09-18T00:31:27Z

Committed 254597@main (48880e3): https://commits.webkit.org/254597@main

Reviewed commits have been landed. Closing PR #4349 and removing active labels.

cdumez self-assigned this Sep 14, 2022

cdumez added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels Sep 14, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 14, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 14, 2022

cdumez force-pushed the nested_workers branch from 60a9a12 to 8d23da1 Compare September 14, 2022 23:05

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 15, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 15, 2022

cdumez force-pushed the nested_workers branch from 8d23da1 to d0f9673 Compare September 15, 2022 02:23

cdumez added 528+ (Nightly build) DOM For bugs specific to XML/HTML DOM elements (including parsing). and removed WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels Sep 15, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 15, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 15, 2022

cdumez force-pushed the nested_workers branch from d0f9673 to bd6c90f Compare September 15, 2022 05:37

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 15, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 15, 2022

cdumez changed the title ~~[WIP] Add support for nested dedicated workers~~ Implement nested Dedicated Workers Sep 15, 2022

cdumez force-pushed the nested_workers branch from bd6c90f to 0aeb36b Compare September 15, 2022 15:30

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 16, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 16, 2022

cdumez force-pushed the nested_workers branch from 0aeb36b to 57882f4 Compare September 16, 2022 04:00

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 16, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 17, 2022

cdumez force-pushed the nested_workers branch from a7a53b2 to 581582d Compare September 17, 2022 16:21

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 17, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 17, 2022

cdumez force-pushed the nested_workers branch from 581582d to 278f75c Compare September 17, 2022 16:42

cdumez force-pushed the nested_workers branch from 278f75c to 7acc4b6 Compare September 17, 2022 17:03

cdumez marked this pull request as ready for review September 17, 2022 20:35

cdumez requested a review from rniwa as a code owner September 17, 2022 20:35

cdumez requested review from youennf, achristensen07, darinadler and geoffreygaren September 17, 2022 20:35

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 17, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 17, 2022

cdumez force-pushed the nested_workers branch from 7acc4b6 to feb5352 Compare September 17, 2022 22:19

darinadler approved these changes Sep 17, 2022

View reviewed changes

cdumez added the merge-queue Applied to send a pull request to merge-queue label Sep 18, 2022

webkit-early-warning-system force-pushed the nested_workers branch from feb5352 to 48880e3 Compare September 18, 2022 00:31

webkit-early-warning-system merged commit 48880e3 into WebKit:main Sep 18, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 18, 2022

kdabir mentioned this pull request Oct 10, 2022

removing init backend hack with polyfill kikko-land/better-absurd-sql#1

Open

codewithkyle mentioned this pull request Oct 19, 2022

Stream worker performance optimizations codewithkyle/jsql#31

Closed

DouglasDwyer mentioned this pull request Apr 9, 2023

Thread tests chemicstry/wasm_thread#16

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement nested Dedicated Workers #4349

Implement nested Dedicated Workers #4349

cdumez commented Sep 14, 2022 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Sep 14, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 14, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 15, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 15, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 15, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 16, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 17, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 17, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 17, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 17, 2022 •

edited

Loading

darinadler left a comment •

edited

Loading

cdumez commented Sep 17, 2022

webkit-commit-queue commented Sep 18, 2022

Implement nested Dedicated Workers #4349

Implement nested Dedicated Workers #4349

Conversation

cdumez commented Sep 14, 2022 • edited by webkit-early-warning-system Loading

48880e3

webkit-early-warning-system commented Sep 14, 2022 • edited Loading

webkit-early-warning-system commented Sep 14, 2022 • edited Loading

webkit-early-warning-system commented Sep 15, 2022 • edited Loading

webkit-early-warning-system commented Sep 15, 2022 • edited Loading

webkit-early-warning-system commented Sep 15, 2022 • edited Loading

webkit-early-warning-system commented Sep 16, 2022 • edited Loading

webkit-early-warning-system commented Sep 17, 2022 • edited Loading

webkit-early-warning-system commented Sep 17, 2022 • edited Loading

webkit-early-warning-system commented Sep 17, 2022 • edited Loading

webkit-early-warning-system commented Sep 17, 2022 • edited Loading

darinadler left a comment • edited Loading

Choose a reason for hiding this comment

cdumez commented Sep 17, 2022

webkit-commit-queue commented Sep 18, 2022

cdumez commented Sep 14, 2022 •

edited by webkit-early-warning-system

Loading

`48880e3`

webkit-early-warning-system commented Sep 14, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 14, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 15, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 15, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 15, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 16, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 17, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 17, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 17, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 17, 2022 •

edited

Loading

darinadler left a comment •

edited

Loading