Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toExistingAtomString() to return an AtomString #440

Merged
merged 0 commits into from Apr 29, 2022
Merged

Update toExistingAtomString() to return an AtomString #440

merged 0 commits into from Apr 29, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 29, 2022

0b2981a

Update toExistingAtomString() to return an AtomString
https://bugs.webkit.org/show_bug.cgi?id=239904

Reviewed by Darin Adler.

Update toExistingAtomString() to return an AtomString instead of a RefPtr<AtomStringImpl >
as it is a bit less awkward to use.

* Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/jit/JITOperations.cpp:
(JSC::getByVal):
(JSC::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:
(JSC::LLInt::getByVal):
* Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:
(JSC::JSC_DEFINE_COMMON_SLOW_PATH):
* Source/JavaScriptCore/runtime/JSString.h:
(JSC::JSString::toExistingAtomString const):
* Source/WTF/wtf/text/StringView.h:
(WTF::StringView::toExistingAtomString const):
* Source/WebCore/bindings/js/JSDOMConvertStrings.h:
(WebCore::Converter<IDLRequiresExistingAtomStringAdaptor<T > >::convert):
* Source/WebCore/dom/TreeScope.cpp:
(WebCore::TreeScope::getElementById const):
* Source/WebCore/platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::loadResourceSynchronously):

Canonical link: https://commits.webkit.org/250133@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@cdumez cdumez self-assigned this Apr 29, 2022
@cdumez cdumez requested review from darinadler and Constellation and removed request for darinadler April 29, 2022 17:35
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 29, 2022
@webkit-early-warning-system
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #440

@webkit-early-warning-system webkit-early-warning-system added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Apr 29, 2022
@cdumez cdumez added WebKit Nightly Build merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged WebKit Nightly Build labels Apr 29, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 0b2981a into WebKit:main Apr 29, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r293627 (250133@main): https://commits.webkit.org/250133@main

Reviewed commits have been landed. Closing PR #440 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Apr 29, 2022
@cdumez cdumez deleted the 239904_toExistingAtomString branch April 29, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants