[Deprecation Reporting] Stub implementation #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentfulgham
added
WebCore Misc.
|
EWS run on previous version of this PR (hash 8dbf8ee) |
webkit-ews-buildbot
added
the
merging-blocked
brentfulgham
removed
the
merging-blocked
brentfulgham
force-pushed
the
eng/Deprecation-Reporting-Stub-implementation
branch
from
8dbf8ee
to
f1f055e
Compare
|
EWS run on previous version of this PR (hash f1f055e) |
webkit-ews-buildbot
added
the
merging-blocked
brentfulgham
removed
the
merging-blocked
brentfulgham
force-pushed
the
eng/Deprecation-Reporting-Stub-implementation
branch
from
f1f055e
to
08d3884
Compare
|
EWS run on previous version of this PR (hash 08d3884) |
cdumez
requested changes
Sep 16, 2022
brentfulgham
force-pushed
the
eng/Deprecation-Reporting-Stub-implementation
branch
from
08d3884
to
0f13c35
Compare
|
EWS run on current version of this PR (hash 0f13c35) |
cdumez
approved these changes
Sep 19, 2022
cdumez
reviewed
Sep 19, 2022
|
|
||
| const AtomString& DeprecationReportBody::deprecationReportType() | ||
| { | ||
| static NeverDestroyed<AtomString> reportType { "deprecation"_s }; |
There was a problem hiding this comment.
Since this is exposed to both main thread and workers, we likely want something like:
static NeverDestroyed<const AtomString> reportType(MAKE_STATIC_STRING_IMPL("deprecation"));
https://bugs.webkit.org/show_bug.cgi?id=245245 <rdar://problem/99988574> Reviewed by Chris Dumez. Import the Web Platform Tests for Deprecation Reporting, create a new Experimental Feature to represent the work, and provide a stub implementation of the report * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/META.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.html: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.js: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/idlharness.any.worker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/deprecation-reporting/w3c-import.log: Added. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/reporting/DeprecationReportBody.cpp: Added. (WebCore::DeprecationReportBody::deprecationReportType): (WebCore::DeprecationReportBody::DeprecationReportBody): (WebCore::DeprecationReportBody::create): (WebCore::DeprecationReportBody::type const): (WebCore::DeprecationReportBody::id const): (WebCore::DeprecationReportBody::anticipatedRemoval const): (WebCore::DeprecationReportBody::message const): (WebCore::DeprecationReportBody::sourceFile const): (WebCore::DeprecationReportBody::lineNumber const): (WebCore::DeprecationReportBody::columnNumber const): (WebCore::DeprecationReportBody::createReportFormDataForViolation const): * Source/WebCore/Modules/reporting/DeprecationReportBody.h: Copied from Source/WebCore/Modules/reporting/TestReportBody.h. (WebCore::DeprecationReportBody::encode const): (WebCore::DeprecationReportBody::decode): (isType): * Source/WebCore/Modules/reporting/DeprecationReportBody.idl: Copied from Source/WebCore/Modules/reporting/ViolationReportType.h. * Source/WebCore/Modules/reporting/ReportingObserver.cpp: (WebCore::isVisibleToReportingObservers): * Source/WebCore/Modules/reporting/TestReportBody.h: * Source/WebCore/Modules/reporting/ViolationReportType.h: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/JSReportBodyCustom.cpp: (WebCore::toJSNewlyCreated): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/loader/PingLoader.cpp: (WebCore::PingLoader::sendViolationReport): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<RefPtr<WebCore::ReportBody>>::encode): (IPC::ArgumentCoder<RefPtr<WebCore::ReportBody>>::decode): Canonical link: https://commits.webkit.org/254634@main
webkit-early-warning-system
force-pushed
the
eng/Deprecation-Reporting-Stub-implementation
branch
from
0f13c35
to
a01206b
Compare
|
Committed 254634@main (a01206b): https://commits.webkit.org/254634@main Reviewed commits have been landed. Closing PR #4409 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a01206b
0f13c35