Turn macOS smooth keyboard scrolling on by default #4453

rr-codes · 2022-09-18T02:44:23Z

`cd1dbd2`

Turn macOS smooth keyboard scrolling on by default
https://bugs.webkit.org/show_bug.cgi?id=228159
rdar://80912063

Reviewed by Tim Horton and Wenson Hsieh.

No tests added.

Set the default value for EventHandlerDrivenSmoothKeyboardScrollingEnabled to true in WebKit.

* LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html:
Updated to reflect non-instananeous scrolling.

* LayoutTests/fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html:
Updated to reflect non-instananeous scrolling.

* LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt:
* LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document.html:
* LayoutTests/platform/mac-wk1/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt: Added.
Updated these tests to reflect the new distance scrolled.

* Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:
`EventHandlerDrivenSmoothKeyboardScrollingEnabled` is now true on default for WebKit.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::startKeyboardScrollAnimationOnEnclosingScrollableContainer):
Added check if renderer is null to fix crash in LayoutTests/fast/forms/select/select-change-type-on-focus.

* Tools/TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
(TestWebKitAPI::didRunJavascript):
(TestWebKitAPI::TEST):
Updated to reflect non-instananeous scrolling.

Canonical link: https://commits.webkit.org/255031@main

2e5a42e

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 api-mac~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-18T02:44:37Z

EWS run on previous version of this PR (hash 01ddee0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk1~~	⏳ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	⏳ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-18T05:04:57Z

EWS run on previous version of this PR (hash d860d1d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-20T02:59:19Z

EWS run on previous version of this PR (hash b39408a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-20T17:55:53Z

EWS run on previous version of this PR (hash 1fe45a0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2022-09-20T18:17:23Z

EWS run on previous version of this PR (hash 843934d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	⏳ 🧪 api-mac	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-20T22:45:50Z

EWS run on previous version of this PR (hash 80417b7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	~~🛠 tv~~	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	~~🛠 tv-sim~~	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	~~🛠 watch~~	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-21T22:09:03Z

EWS run on previous version of this PR (hash 36da471)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	⏳ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-28T17:19:43Z

EWS run on previous version of this PR (hash 330db84)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-29T02:14:45Z

EWS run on previous version of this PR (hash 470f749)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2022-09-29T02:16:51Z

EWS run on previous version of this PR (hash 0a24e0a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-29T03:08:17Z

EWS run on previous version of this PR (hash b7f3780)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html

LayoutTests/fast/repaint/fixed-move-after-keyboard-scroll.html

LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document.html

hortont424 · 2022-09-29T03:28:36Z

Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml

@@ -275,7 +275,7 @@ EventHandlerDrivenSmoothKeyboardScrollingEnabled:
  WebKitLegacy:
   default: false
  WebKit:
-   default: false
+   default: true


Tools/TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp

webkit-early-warning-system · 2022-09-29T17:22:14Z

EWS run on previous version of this PR (hash b193081)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-29T17:54:28Z

EWS run on previous version of this PR (hash 25b4e82)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	💥 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html

webkit-early-warning-system · 2022-09-30T05:08:37Z

EWS run on current version of this PR (hash 2e5a42e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 api-mac~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

https://bugs.webkit.org/show_bug.cgi?id=228159 rdar://80912063 Reviewed by Tim Horton and Wenson Hsieh. No tests added. Set the default value for EventHandlerDrivenSmoothKeyboardScrollingEnabled to true in WebKit. * LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html: Updated to reflect non-instananeous scrolling. * LayoutTests/fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html: Updated to reflect non-instananeous scrolling. * LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt: * LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document.html: * LayoutTests/platform/mac-wk1/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt: Added. Updated these tests to reflect the new distance scrolled. * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: `EventHandlerDrivenSmoothKeyboardScrollingEnabled` is now true on default for WebKit. * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::startKeyboardScrollAnimationOnEnclosingScrollableContainer): Added check if renderer is null to fix crash in LayoutTests/fast/forms/select/select-change-type-on-focus. * Tools/TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp: (TestWebKitAPI::didRunJavascript): (TestWebKitAPI::TEST): Updated to reflect non-instananeous scrolling. Canonical link: https://commits.webkit.org/255031@main

webkit-commit-queue · 2022-09-30T16:36:41Z

Committed 255031@main (cd1dbd2): https://commits.webkit.org/255031@main

Reviewed commits have been landed. Closing PR #4453 and removing active labels.

rr-codes requested a review from cdumez as a code owner September 18, 2022 02:44

rr-codes self-assigned this Sep 18, 2022

rr-codes added Scrolling Bugs related to main thread and off-main thread scrolling WebKit Local Build labels Sep 18, 2022

rr-codes marked this pull request as draft September 18, 2022 02:44

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 18, 2022

rr-codes removed the merging-blocked Applied to prevent a change from being merged label Sep 18, 2022

rr-codes force-pushed the eng/80912063 branch from 01ddee0 to d860d1d Compare September 18, 2022 05:04

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 18, 2022

rr-codes removed the merging-blocked Applied to prevent a change from being merged label Sep 20, 2022

rr-codes force-pushed the eng/80912063 branch from d860d1d to b39408a Compare September 20, 2022 02:59

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 20, 2022

rr-codes removed the merging-blocked Applied to prevent a change from being merged label Sep 20, 2022

rr-codes force-pushed the eng/80912063 branch from b39408a to 1fe45a0 Compare September 20, 2022 17:55

rr-codes force-pushed the eng/80912063 branch from 1fe45a0 to 843934d Compare September 20, 2022 18:16

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 20, 2022

rr-codes removed the merging-blocked Applied to prevent a change from being merged label Sep 20, 2022

rr-codes force-pushed the eng/80912063 branch from 843934d to 80417b7 Compare September 20, 2022 22:45

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 21, 2022

rr-codes removed the merging-blocked Applied to prevent a change from being merged label Sep 21, 2022

rr-codes force-pushed the eng/80912063 branch from 80417b7 to 36da471 Compare September 21, 2022 22:07

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 22, 2022

rr-codes removed the merging-blocked Applied to prevent a change from being merged label Sep 22, 2022

rr-codes force-pushed the eng/80912063 branch from 0e629c9 to 330db84 Compare September 28, 2022 17:19

rr-codes force-pushed the eng/80912063 branch from 330db84 to 470f749 Compare September 29, 2022 02:14

rr-codes force-pushed the eng/80912063 branch from 470f749 to 0a24e0a Compare September 29, 2022 02:16

rr-codes force-pushed the eng/80912063 branch from 0a24e0a to b7f3780 Compare September 29, 2022 03:08

rr-codes requested a review from hortont424 September 29, 2022 03:08

rr-codes marked this pull request as ready for review September 29, 2022 03:08

hortont424 reviewed Sep 29, 2022

View reviewed changes

whsieh approved these changes Sep 29, 2022

View reviewed changes

Tools/TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp Show resolved Hide resolved

rr-codes force-pushed the eng/80912063 branch from b7f3780 to b193081 Compare September 29, 2022 17:21

rr-codes force-pushed the eng/80912063 branch from b193081 to 25b4e82 Compare September 29, 2022 17:54

rr-codes requested review from hortont424 and whsieh September 29, 2022 17:54

hortont424 approved these changes Sep 30, 2022

View reviewed changes

LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html Show resolved Hide resolved

rr-codes force-pushed the eng/80912063 branch from 25b4e82 to 2e5a42e Compare September 30, 2022 05:08

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

rr-codes added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Sep 30, 2022

webkit-commit-queue force-pushed the eng/80912063 branch from 2e5a42e to cd1dbd2 Compare September 30, 2022 16:36

webkit-commit-queue merged commit cd1dbd2 into WebKit:main Sep 30, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 30, 2022

Ahmad-S792 mentioned this pull request Feb 5, 2023

Turn macOS smooth keyboard scrolling on by default #2714

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turn macOS smooth keyboard scrolling on by default #4453

Turn macOS smooth keyboard scrolling on by default #4453

rr-codes commented Sep 18, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 18, 2022 •

edited

webkit-early-warning-system commented Sep 18, 2022 •

edited

webkit-early-warning-system commented Sep 20, 2022 •

edited

webkit-early-warning-system commented Sep 20, 2022 •

edited

webkit-early-warning-system commented Sep 20, 2022 •

edited

webkit-early-warning-system commented Sep 20, 2022 •

edited

webkit-early-warning-system commented Sep 21, 2022 •

edited

webkit-early-warning-system commented Sep 28, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

hortont424 Sep 29, 2022

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 30, 2022 •

edited

webkit-commit-queue commented Sep 30, 2022

Turn macOS smooth keyboard scrolling on by default #4453

Turn macOS smooth keyboard scrolling on by default #4453

Conversation

rr-codes commented Sep 18, 2022 • edited by webkit-early-warning-system

cd1dbd2

webkit-early-warning-system commented Sep 18, 2022 • edited

webkit-early-warning-system commented Sep 18, 2022 • edited

webkit-early-warning-system commented Sep 20, 2022 • edited

webkit-early-warning-system commented Sep 20, 2022 • edited

webkit-early-warning-system commented Sep 20, 2022 • edited

webkit-early-warning-system commented Sep 20, 2022 • edited

webkit-early-warning-system commented Sep 21, 2022 • edited

webkit-early-warning-system commented Sep 28, 2022 • edited

webkit-early-warning-system commented Sep 29, 2022 • edited

webkit-early-warning-system commented Sep 29, 2022 • edited

webkit-early-warning-system commented Sep 29, 2022 • edited

hortont424 Sep 29, 2022

Choose a reason for hiding this comment

webkit-early-warning-system commented Sep 29, 2022 • edited

webkit-early-warning-system commented Sep 29, 2022 • edited

webkit-early-warning-system commented Sep 30, 2022 • edited

webkit-commit-queue commented Sep 30, 2022

rr-codes commented Sep 18, 2022 •

edited by webkit-early-warning-system

`cd1dbd2`

webkit-early-warning-system commented Sep 18, 2022 •

edited

webkit-early-warning-system commented Sep 18, 2022 •

edited

webkit-early-warning-system commented Sep 20, 2022 •

edited

webkit-early-warning-system commented Sep 20, 2022 •

edited

webkit-early-warning-system commented Sep 20, 2022 •

edited

webkit-early-warning-system commented Sep 20, 2022 •

edited

webkit-early-warning-system commented Sep 21, 2022 •

edited

webkit-early-warning-system commented Sep 28, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 29, 2022 •

edited

webkit-early-warning-system commented Sep 30, 2022 •

edited