Skip invalid SVG+currentcolor tests. #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdubet
added
Tools / Tests
|
EWS run on previous version of this PR (hash 93ff1a1)
|
mdubet
force-pushed
the
skip-invalid-svg-test
branch
from
93ff1a1
to
c7f8b4c
Compare
|
nt1m
approved these changes
Sep 19, 2022
Comment on lines
+6048
to
+6050
| # Old SVG+currentcolor tests are incorrect https://bugs.webkit.org/show_bug.cgi?id=245400 | ||
| imported/w3c/web-platform-tests/svg/import/color-prop-05-t-manual.svg [ Skip ] | ||
| svg/W3C-SVG-1.1-SE/color-prop-05-t.svg [ Skip ] |
There was a problem hiding this comment.
We should look into de-duplicating these tests, and fixing it upstream as well. I can take care of that.
There was a problem hiding this comment.
Yes indeed, there is bugzilla about those de-duplication tasks https://bugs.webkit.org/show_bug.cgi?id=215135
nt1m
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=245400 Reviewed by Tim Nguyen. With SVG 2 and Color level 5, it should define a rectangle fill in red (not lime). This is the behaviour of both Gecko and Blink. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/254649@main
webkit-early-warning-system
force-pushed
the
skip-invalid-svg-test
branch
from
c7f8b4c
to
54fc90a
Compare
|
Committed 254649@main (54fc90a): https://commits.webkit.org/254649@main Reviewed commits have been landed. Closing PR #4508 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
54fc90a
c7f8b4c
🛠 mac🛠 wpe🛠 🧪 win🛠 ios-sim🛠 mac-debug🛠 gtk🛠 wincairo🧪 ios-wk2🛠 mac-AS-debug🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🛠 tv🧪 mac-wk1🛠 tv-sim🧪 mac-wk2🛠 watch🧪 mac-AS-debug-wk2🛠 watch-sim🧪 mac-wk2-stress