[Live Text] Avoid injecting recognized text consisting of single words or letters in tiny images #4512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whsieh
added
Platform
|
EWS run on current version of this PR (hash e9a99f8) |
whsieh
requested review from
megangardner,
pxlcoder,
rr-codes and
hortont424
rr-codes
reviewed
Sep 20, 2022
| if (!elements.root) | ||
| return; | ||
|
|
||
| { |
There was a problem hiding this comment.
why is this separate scope needed?
There was a problem hiding this comment.
Oh, I wrote it this way to ensure that nothing below tries to reuse renderer here. If anything updates layout below and causes the image to recreate its renderer, then this pointer could point to a destroyed object.
rr-codes
approved these changes
Sep 20, 2022
hortont424
approved these changes
Sep 20, 2022
|
Thanks for the reviews! |
…s or letters in tiny images https://bugs.webkit.org/show_bug.cgi?id=245404 rdar://99490753 Reviewed by Tim Horton. Add a basic heuristic to avoid injecting Live Text in small images, if the recognized text consists of only a single word or letter. Currently, this causes images to become selectable in many instances where there's little to no utility in being able to select text — for instance, in image buttons or links that consist of an icon, such as an "x". Test: fast/images/text-recognition/avoid-image-overlay-in-small-image.html * LayoutTests/fast/images/text-recognition/avoid-image-overlay-in-small-image-expected.txt: Added. * LayoutTests/fast/images/text-recognition/avoid-image-overlay-in-small-image.html: Added. * Source/WebCore/dom/ImageOverlay.cpp: (WebCore::ImageOverlay::updateWithTextRecognitionResult): To do this, we shuffle around some logic for creating and appending the UA shadow DOM elements used to implement Live Text, such that we exit early and avoid installing a shadow root altogether in the case where the image is smaller than an arbitrary threshold (64px), and the text we're about to inject consists of a single piece of child text. Canonical link: https://commits.webkit.org/254671@main
webkit-early-warning-system
force-pushed
the
eng/245404
branch
from
e9a99f8
to
03e0d55
Compare
|
Committed 254671@main (03e0d55): https://commits.webkit.org/254671@main Reviewed commits have been landed. Closing PR #4512 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
03e0d55
e9a99f8
🧪 mac-AS-debug-wk2