[JSC] DFG AI should attempt to remove @tryGetById for String.replace #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
JavaScriptCore
|
EWS run on previous version of this PR (hash 21367ae) |
rkirsling
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Seems okay, but...
- Ensure RegExp.prototype's properties via watchpoints.
- Check structure in AI, and ensure that this structure is one for RegExpObject, its [[Prototype]] is RegExp.prototype, it is cacheable,
and it does not have properties for particular names.
...(1) appears to be existing functionality and not actually part of this patch?
| @@ -3424,12 +3425,56 @@ bool AbstractInterpreter<AbstractStateType>::executeEffects(unsigned clobberLimi | |||
| makeHeapTopForNode(node); | |||
| break; | |||
|
|
|||
| case TryGetById: | |||
| case TryGetById: { | |||
| // This is very adhoc, but @tryGetById is not usually used in user code, and it is used adhocly in very limited places. | |||
There was a problem hiding this comment.
Seems like you don't need the "usually"?
Yes |
Constellation
force-pushed
the
eng/JSC-DFG-AI-should-attempt-to-remove-tryGetById-for-String-replace
branch
from
21367ae
to
cc558c3
Compare
Constellation
added
the
merge-queue
|
EWS run on current version of this PR (hash cc558c3) |
https://bugs.webkit.org/show_bug.cgi?id=245418 Reviewed by Ross Kirsling. @tryGetById is adhoc one: it is used only in builtin code and used in very limited places. So this patch introduces adhoc folding rules for @tryGetById to remove TryGetById attached before String.replace. Unfortunately these @tryGetById are not usually removed since it is adhocly attached in DFG fixup phase. In this patch, 1. Ensure RegExp.prototype's properties via watchpoints. 2. Check structure in AI, and ensure that this structure is one for RegExpObject, its [[Prototype]] is RegExp.prototype, it is cacheable, and it does not have properties for particular names. Then we fold TryGetById to RegExp's specific properties values. It eliminates these TryGetById and improves String.replace in DFG / FTL by 65% (e.g. string-replace). ToT Patched string-replace-generic 33.0472+-0.1132 ^ 31.9405+-0.1483 ^ definitely 1.0346x faster string-replace 3.3774+-0.0951 ^ 2.0387+-0.0476 ^ definitely 1.6566x faster put-by-val-with-string-replace-and-transition 4.4385+-0.0233 4.4319+-0.0188 string-replace-benchmark 83.8759+-0.1186 ^ 83.4655+-0.2393 ^ definitely 1.0049x faster string-replace-string 380.3462+-0.7600 379.2646+-1.0203 string-replace-empty 3.2455+-0.0406 ^ 2.0051+-0.1350 ^ definitely 1.6186x faster * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Canonical link: https://commits.webkit.org/254717@main
|
Committed 254717@main (e289c32): https://commits.webkit.org/254717@main Reviewed commits have been landed. Closing PR #4522 and removing active labels. |
webkit-early-warning-system
force-pushed
the
eng/JSC-DFG-AI-should-attempt-to-remove-tryGetById-for-String-replace
branch
from
cc558c3
to
e289c32
Compare
webkit-commit-queue
removed
the
merge-queue
Constellation
deleted the
eng/JSC-DFG-AI-should-attempt-to-remove-tryGetById-for-String-replace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e289c32
cc558c3
🛠 mac🛠 wpe🛠 🧪 win🛠 mac-debug🛠 wincairo🧪 ios-wk2🛠 mac-AS-debug🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🛠 tv🧪 mac-wk1🛠 tv-sim🧪 mac-wk2🛠 watch🧪 mac-AS-debug-wk2🛠 watch-sim🧪 mac-wk2-stress