Change unclear Color::isValid() to explicit isCurrentColor(). #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdubet
added
WebCore Misc.
|
EWS run on previous version of this PR (hash 12c3b9d)
|
mdubet
force-pushed
the
use-correctly-name-fn-is-currentcolor
branch
from
12c3b9d
to
20fd0a0
Compare
|
EWS run on previous version of this PR (hash 20fd0a0) |
|
Please describe why this change is valid, so it's clear to other people reading the patch. Also, |
mdubet
force-pushed
the
use-correctly-name-fn-is-currentcolor
branch
from
20fd0a0
to
87eef41
Compare
mdubet
changed the title
|
EWS run on current version of this PR (hash 87eef41)
|
graouts
approved these changes
Sep 20, 2022
webkit-ews-buildbot
added
the
merging-blocked
nt1m
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=245424 Reviewed by Antoine Quint. Due to the representation of "current color" as "invalid color" in WebCore, they are two functionally equivalent functions in the codebase: - Color::isValid() - RenderStyle::isCurrentColor(Color) which is implemented as "return !color.isValid()". The second one makes the intention of the check clearer and should be preferred. * Source/WebCore/animation/CSSPropertyAnimation.cpp: * Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.cpp: (WebCore::SVGAnimationColorFunction::calculateDistance const): Canonical link: https://commits.webkit.org/254683@main
webkit-early-warning-system
force-pushed
the
use-correctly-name-fn-is-currentcolor
branch
from
87eef41
to
0b28244
Compare
|
Committed 254683@main (0b28244): https://commits.webkit.org/254683@main Reviewed commits have been landed. Closing PR #4528 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0b28244
87eef41
🛠 mac🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress