[JSC] Clean up wasm AirIRGenerator FP truncation #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjgriego
added
JavaScriptCore
|
EWS run on previous version of this PR (hash 0e64991) |
jjgriego
force-pushed
the
eng/JSC-Clean-up-wasm-AirIRGenerator-FP-truncation
branch
from
0e64991
to
4e5598d
Compare
|
EWS run on previous version of this PR (hash 4e5598d) |
jjgriego
force-pushed
the
eng/JSC-Clean-up-wasm-AirIRGenerator-FP-truncation
branch
from
4e5598d
to
2195b79
Compare
|
EWS run on previous version of this PR (hash 2195b79) |
|
(^ rebase and fix typo in comment) |
jjgriego
force-pushed
the
eng/JSC-Clean-up-wasm-AirIRGenerator-FP-truncation
branch
from
2195b79
to
01380fd
Compare
|
EWS run on current version of this PR (hash 01380fd) |
https://bugs.webkit.org/show_bug.cgi?id=245436 Reviewed by Justin Michaud. The implementation for all of the (checked and saturated) floating point to integer truncations ends up being really duplicative--we have code for the patchpoints to generate the appropriate instructions twice for each flavor of this operation and code for the bounds checking needed is duplicated many times. This patch adds a new method for generating only the code for an unchecked truncation; a table of the output ranges for each flavor, and uses both to have a single implementation for both the checked and saturating versions of each truncation instruction. Also avoids clobbering the macro scratch registers on ARM64 for some variants of the truncation (the ones resulting in U64s) since the macro assembler doesn't seem to actually need them on that architecture. Relying on the existing test suite; this shouldn't really change the generated code, except for the change to the macro scratch register clobbers on ARM64. * Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::lookupTruncationRange): (JSC::Wasm::AirIRGenerator::addUncheckedFloatingPointTruncation): (JSC::Wasm::AirIRGenerator::truncSaturated): (JSC::Wasm::AirIRGenerator::addCheckedFloatingPointTruncation): (JSC::Wasm::AirIRGenerator::addOp<OpType::I32TruncSF64>): (JSC::Wasm::AirIRGenerator::addOp<OpType::I32TruncSF32>): (JSC::Wasm::AirIRGenerator::addOp<OpType::I32TruncUF64>): (JSC::Wasm::AirIRGenerator::addOp<OpType::I32TruncUF32>): (JSC::Wasm::AirIRGenerator::addOp<OpType::I64TruncSF64>): (JSC::Wasm::AirIRGenerator::addOp<OpType::I64TruncUF64>): (JSC::Wasm::AirIRGenerator::addOp<OpType::I64TruncSF32>): (JSC::Wasm::AirIRGenerator::addOp<OpType::I64TruncUF32>): Canonical link: https://commits.webkit.org/254875@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Clean-up-wasm-AirIRGenerator-FP-truncation
branch
from
01380fd
to
b07e2d5
Compare
|
Committed 254875@main (b07e2d5): https://commits.webkit.org/254875@main Reviewed commits have been landed. Closing PR #4539 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b07e2d5
01380fd
🛠 mac-debug🧪 ios-wk2🧪 mac-AS-debug-wk2