Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK] Do not use GLOB to collect po files #4543

Merged
merged 1 commit into from Sep 21, 2022
Merged

[GTK] Do not use GLOB to collect po files #4543

merged 1 commit into from Sep 21, 2022

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Sep 20, 2022 •
edited by webkit-early-warning-system

@mcatanzaro mcatanzaro requested a review from a team as a code owner September 20, 2022 19:31
@mcatanzaro mcatanzaro self-assigned this Sep 20, 2022
@mcatanzaro mcatanzaro added WebKit Nightly Build WebKitGTK Bugs related to the Gtk API layer. labels Sep 20, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 7f1750d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Sep 21, 2022
@mcatanzaro
[GTK] Do not use GLOB to collect po files
b657e12 
https://bugs.webkit.org/show_bug.cgi?id=245440

Reviewed by Adrian Perez de Castro.

* Source/WebCore/platform/gtk/po/CMakeLists.txt:

Canonical link: https://commits.webkit.org/254706@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/GTK-Do-not-use-GLOB-to-collect-po-files branch from 7f1750d to b657e12 Compare September 21, 2022 03:20
@webkit-commit-queue
Copy link
Collaborator

Committed 254706@main (b657e12): https://commits.webkit.org/254706@main

Reviewed commits have been landed. Closing PR #4543 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit b657e12 into WebKit:main Sep 21, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 21, 2022
@mcatanzaro mcatanzaro deleted the eng/GTK-Do-not-use-GLOB-to-collect-po-files branch December 22, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

@donny-dont donny-dont Awaiting requested review from donny-dont

Assignees

@mcatanzaro mcatanzaro

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
4 participants
@mcatanzaro @webkit-early-warning-system @webkit-commit-queue @aperezdc