document.open() should remove the initial about:blank-ness of the document #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
Page Loading
|
EWS run on previous version of this PR (hash 1bb4005) |
cdumez
requested review from
youennf,
achristensen07,
darinadler and
geoffreygaren
youennf
reviewed
Sep 21, 2022
Source/WebCore/dom/Document.cpp
Outdated
| if (m_frame) | ||
| if (m_frame) { | ||
| // Calling window.open() counts as committing the first real document load. | ||
| WTFLogAlways("CHRIS: state was %u", (unsigned)m_frame->loader().stateMachine().stateForDebugging()); |
There was a problem hiding this comment.
Probably do not want those logs
Source/WebCore/dom/Document.cpp
Outdated
| @@ -3043,8 +3043,16 @@ ExceptionOr<void> Document::open(Document* entryDocument) | |||
| if (ScriptableDocumentParser* parser = scriptableDocumentParser()) | |||
| parser->setWasCreatedByScript(true); | |||
|
|
|||
| if (m_frame) | |||
| if (m_frame) { | |||
| // Calling window.open() counts as committing the first real document load. | |||
There was a problem hiding this comment.
Can we add a pointer to the spec, either here or in commit message
cdumez
force-pushed
the
245445_document_open_about_blank
branch
from
1bb4005
to
b4022bc
Compare
|
EWS run on previous version of this PR (hash b4022bc)
|
🧪 mac-AS-debug-wk2
youennf
approved these changes
Sep 21, 2022
darinadler
approved these changes
Sep 21, 2022
Source/WebCore/dom/Document.cpp
Outdated
| if (m_frame) { | ||
| // Set document's is initial about:blank to false. | ||
| // https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#document-open-steps (step 13) | ||
| if (m_frame->loader().stateMachine().committingFirstRealLoad()) |
There was a problem hiding this comment.
This looks like maybe it should be a FrameLoader function.
cdumez
force-pushed
the
245445_document_open_about_blank
branch
from
b4022bc
to
b123149
Compare
|
EWS run on current version of this PR (hash b123149)
|
…ument https://bugs.webkit.org/show_bug.cgi?id=245445 Reviewed by Darin Adler and Youenn Fablet. document.open() should remove the initial about:blank-ness of the document. This aligns our behavior with Firefox and Chrome. * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/remove-initial-about-blankness.window-expected.txt: * Source/WebCore/dom/Document.cpp: (WebCore::Document::open): Canonical link: https://commits.webkit.org/254747@main
webkit-early-warning-system
force-pushed
the
245445_document_open_about_blank
branch
from
b123149
to
dc6d5ef
Compare
|
Committed 254747@main (dc6d5ef): https://commits.webkit.org/254747@main Reviewed commits have been landed. Closing PR #4546 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dc6d5ef
b123149
🛠 mac-debug🛠 tv🛠 tv-sim🛠 watch🛠 watch-sim