Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert [254089@main] Remove _WKWebsiteDataStore.h #4554

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Revert [254089@main] Remove _WKWebsiteDataStore.h #4554

merged 1 commit into from
Sep 21, 2022

Conversation

szewai
Copy link
Contributor

@szewai szewai commented Sep 21, 2022 •
edited by webkit-early-warning-system

86a0b3b

Revert [254089@main] Remove _WKWebsiteDataStore.h
https://bugs.webkit.org/show_bug.cgi?id=245456

Reviewed by Alexey Proskuryakov.

There are still clients using the header, see rdar://100075792.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.h: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/254730@main

58e152a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
  🛠 tv ✅ 🧪 mac-wk1
  🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge   🛠 watch ✅ 🧪 mac-AS-debug-wk2
  🛠 watch-sim ✅ 🧪 mac-wk2-stress

@szewai szewai requested a review from cdumez as a code owner September 21, 2022 01:02
@szewai szewai self-assigned this Sep 21, 2022
@szewai szewai added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels Sep 21, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 58e152a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
  🛠 tv ✅ 🧪 mac-wk1
  🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge   🛠 watch ✅ 🧪 mac-AS-debug-wk2
  🛠 watch-sim ✅ 🧪 mac-wk2-stress

aproskuryakov
aproskuryakov approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@aproskuryakov aproskuryakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@szewai szewai added the merge-queue Applied to send a pull request to merge-queue label Sep 21, 2022
@szewai
Revert [254089@main] Remove _WKWebsiteDataStore.h
86a0b3b 
https://bugs.webkit.org/show_bug.cgi?id=245456

Reviewed by Alexey Proskuryakov.

There are still clients using the header, see rdar://100075792.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.h: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/254730@main
@webkit-commit-queue
Copy link
Collaborator

Committed 254730@main (86a0b3b): https://commits.webkit.org/254730@main

Reviewed commits have been landed. Closing PR #4554 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 86a0b3b into WebKit:main Sep 21, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 21, 2022
@szewai szewai deleted the eng/Revert-254089main branch November 14, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aproskuryakov aproskuryakov aproskuryakov approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@achristensen07 achristensen07 Awaiting requested review from achristensen07

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@szewai szewai

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@szewai @webkit-early-warning-system @webkit-commit-queue @aproskuryakov