Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Inspector: DOM tree is missing parts of the DOM tree when remotely inspecting iOS devices #4585

Closed
wants to merge 0 commits into from
Closed

Web Inspector: DOM tree is missing parts of the DOM tree when remotely inspecting iOS devices #4585

wants to merge 0 commits into from

Conversation

patrickangle
Copy link
Contributor

@patrickangle patrickangle commented Sep 22, 2022 •
edited by webkit-early-warning-system

4671450

Web Inspector: DOM tree is missing parts of the DOM tree when remotely inspecting iOS devices
https://bugs.webkit.org/show_bug.cgi?id=245314
rdar://100203923

Reviewed by Alexey Proskuryakov.

A typo in our compatibility handling for older protocol versions caused us to not actually add all the DOMNodes to our
frontend representation of the DOM tree.

* Source/WebInspectorUI/UserInterface/Models/DOMNode.js:
(WI.DOMNode):

Canonical link: https://commits.webkit.org/254744@main

e5e6624

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🛠 ios-sim   🛠 mac-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
  🛠 tv   🧪 mac-wk1
  🛠 tv-sim   🧪 mac-wk2
❌ 🛠 🧪 merge   🛠 watch   🧪 mac-AS-debug-wk2
  🛠 watch-sim   🧪 mac-wk2-stress

@patrickangle patrickangle self-assigned this Sep 22, 2022
@patrickangle patrickangle added Safari Technology Preview Web Inspector Bugs related to the WebKit Web Inspector. labels Sep 22, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash e5e6624)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🛠 ios-sim   🛠 mac-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
  🛠 tv   🧪 mac-wk1
  🛠 tv-sim   🧪 mac-wk2
❌ 🛠 🧪 merge   🛠 watch   🧪 mac-AS-debug-wk2
  🛠 watch-sim   🧪 mac-wk2-stress

@patrickangle patrickangle added the merge-queue Applied to send a pull request to merge-queue label Sep 22, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 254744@main (4671450): https://commits.webkit.org/254744@main

Reviewed commits have been landed. Closing PR #4585 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aproskuryakov aproskuryakov aproskuryakov approved these changes

@dcrousso dcrousso Awaiting requested review from dcrousso

Assignees

@patrickangle patrickangle

Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Milestone
No milestone
4 participants
@patrickangle @webkit-early-warning-system @webkit-commit-queue @aproskuryakov