getComputedStyle() on transform property should return function list #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash cd50a8f)
|
🧪 ios-wk2
webkit-ews-buildbot
added
the
merging-blocked
|
The two regressions on @anttijk do you think this is an acceptable change? It really only manifests itself through the computed style. We should add an allow-list for |
anttijk
approved these changes
Sep 22, 2022
graouts
force-pushed
the
bug-23924-transform-serialization
branch
from
cd50a8f
to
84f06ce
Compare
|
EWS run on current version of this PR (hash 84f06ce)
|
anttijk
reviewed
Sep 22, 2022
| FAIL KeyframeEffect.getKeyframes() returns expected values for animations with CSS variables as keyframe values assert_equals: value for 'transform' on Keyframe #1 should match expected "translate(100px)" but got "matrix(1, 0, 0, 1, 100, 0)" | ||
| FAIL KeyframeEffect.getKeyframes() returns expected values for animations with CSS variables as keyframe values assert_equals: value for 'transform' on Keyframe #1 should match expected "translate(100px)" but got "translate(100px, 0px)" |
There was a problem hiding this comment.
This is still not entirely canonical?
There was a problem hiding this comment.
No, there seems to be some differences between expected serialization that I haven't fully worked out. Fixing this is the next item on my to-do list.
graouts
added
merge-queue
webkit-early-warning-system
force-pushed
the
bug-23924-transform-serialization
branch
from
84f06ce
to
914e153
Compare
https://bugs.webkit.org/show_bug.cgi?id=23924 Reviewed by Antti Koivisto. We should serialize the "transform" property to a series of individual functions to match the individual operations found in the TransformOperations value. To determine when we should be doing this, we pass a nullptr value as the renderer when calling valueForPropertyInStyle() on the ComputedStyleExtractor in KeyframeEffect::getKeyframes() and WebAnimation::commitStyles(). Note the slight regression with first-letter and first-line tests where we now expose the "transform" property not being rejected at parse-time, bug 245523 will address this. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-inline-value-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt: * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::getKeyframes): * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::commitStyles): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::computedTransform): Canonical link: https://commits.webkit.org/254760@main
webkit-early-warning-system
force-pushed
the
bug-23924-transform-serialization
branch
from
914e153
to
ae44d0c
Compare
|
Committed 254760@main (ae44d0c): https://commits.webkit.org/254760@main Reviewed commits have been landed. Closing PR #4591 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ae44d0c
84f06ce
🛠 mac-debug🛠 tv🧪 mac-wk1🛠 tv-sim🛠 watch🧪 mac-AS-debug-wk2🛠 watch-sim