[macOS] RunningBoard assertions regress page load time #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salinas-miguel
added
WebKit Nightly Build
WebKit Process Model
|
EWS run on current version of this PR (hash 1ebb757) |
https://bugs.webkit.org/show_bug.cgi?id=245605 rdar://100342604 Revert 1f756e6 Reviewed by Chris Dumez. * Source/WTF/wtf/PlatformUse.h: * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/Scripts/process-entitlements.sh: * Source/WebKit/Scripts/update-info-plist-for-runningboard.sh: Removed. * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h: (WebKit::XPCServiceInitializer): * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm: (WebKit::XPCServiceExit): * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::didFinishLaunching): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::shouldLeakBoost): * Source/WebKit/UIProcess/ProcessAssertion.cpp: * Source/WebKit/UIProcess/ProcessAssertion.h: * Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm: Renamed from Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm. (assertionsWorkQueue): (processHasActiveRunTimeLimitation): (+[WKProcessAssertionBackgroundTaskManager shared]): (-[WKProcessAssertionBackgroundTaskManager init]): (-[WKProcessAssertionBackgroundTaskManager dealloc]): (-[WKProcessAssertionBackgroundTaskManager addAssertionNeedingBackgroundTask:]): (-[WKProcessAssertionBackgroundTaskManager removeAssertionNeedingBackgroundTask:]): (-[WKProcessAssertionBackgroundTaskManager _notifyAssertionsOfImminentSuspension]): (-[WKProcessAssertionBackgroundTaskManager _scheduleReleaseTask]): (-[WKProcessAssertionBackgroundTaskManager _cancelPendingReleaseTask]): (-[WKProcessAssertionBackgroundTaskManager _hasBackgroundTask]): (-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]): (-[WKProcessAssertionBackgroundTaskManager assertionWillInvalidate:]): (-[WKProcessAssertionBackgroundTaskManager assertion:didInvalidateWithError:]): (-[WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpiration]): (-[WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpirationOnMainThread]): (-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]): (-[WKProcessAssertionBackgroundTaskManager setProcessStateMonitorEnabled:]): (-[WKRBSAssertionDelegate dealloc]): (-[WKRBSAssertionDelegate assertionWillInvalidate:]): (-[WKRBSAssertionDelegate assertion:didInvalidateWithError:]): (WebKit::runningBoardNameForAssertionType): (WebKit::runningBoardDomainForAssertionType): (WebKit::ProcessAssertion::ProcessAssertion): (WebKit::ProcessAssertion::remainingRunTimeInSeconds): (WebKit::ProcessAssertion::acquireAsync): (WebKit::ProcessAssertion::acquireSync): (WebKit::ProcessAssertion::~ProcessAssertion): (WebKit::ProcessAssertion::processAssertionWillBeInvalidated): (WebKit::ProcessAssertion::processAssertionWasInvalidated): (WebKit::ProcessAssertion::isValid const): (WebKit::ProcessAndUIAssertion::updateRunInBackgroundCount): (WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion): (WebKit::ProcessAndUIAssertion::setProcessStateMonitorEnabled): (WebKit::ProcessAndUIAssertion::~ProcessAndUIAssertion): (WebKit::ProcessAndUIAssertion::uiAssertionWillExpireImminently): (WebKit::ProcessAndUIAssertion::processAssertionWasInvalidated): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/254812@main
webkit-early-warning-system
force-pushed
the
revert-runningboard-macos
branch
from
1ebb757
to
ba9eae0
Compare
|
Committed 254812@main (ba9eae0): https://commits.webkit.org/254812@main Reviewed commits have been landed. Closing PR #4653 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ba9eae0
1ebb757
🛠 mac🛠 🧪 win🛠 mac-debug🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🛠 🧪 jsc🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress