Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreviewed, add missing comma in Navigator+ScreenWakeLock.idl #4689

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Unreviewed, add missing comma in Navigator+ScreenWakeLock.idl #4689

merged 1 commit into from
Sep 25, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Sep 25, 2022 •
edited by webkit-early-warning-system

@cdumez cdumez self-assigned this Sep 25, 2022
@cdumez cdumez added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels Sep 25, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 2c13b96)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-debug   🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim   🧪 mac-wk2
✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim   🧪 mac-wk2-stress

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 25, 2022
@cdumez
Unreviewed, add missing comma in Navigator+ScreenWakeLock.idl
cf5cf0c 
https://bugs.webkit.org/show_bug.cgi?id=245647
<rdar://100387059>

* Source/WebCore/Modules/screen-wake-lock/Navigator+ScreenWakeLock.idl:

Canonical link: https://commits.webkit.org/254844@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Add-missing-comma-in-NavigatorScreenWakeLock-idl branch from 2c13b96 to cf5cf0c Compare September 25, 2022 21:03
@webkit-commit-queue
Copy link
Collaborator

Committed 254844@main (cf5cf0c): https://commits.webkit.org/254844@main

Reviewed commits have been landed. Closing PR #4689 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit cf5cf0c into WebKit:main Sep 25, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cdumez cdumez

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
3 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue