Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK][WPE] Wrong close status code returned when the client closes a WebSocket #4787

Closed
wants to merge 0 commits into from

Conversation

magomez
Copy link
Contributor

@magomez magomez commented Sep 28, 2022

977e507

[GTK][WPE] Wrong close status code returned when the client closes a WebSocket
https://bugs.webkit.org/show_bug.cgi?id=245774

Reviewed by Carlos Garcia Campos.

Return SOUP_WEBSOCKET_CLOSE_ABNORMAL when the WebSocket connection is not properly closed
and soup_websocket_connection_get_close_code() returns 0.

* Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp:
(WebKit::WebSocketTask::didCloseCallback):

Canonical link: https://commits.webkit.org/254988@main

c8dba80

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@magomez magomez requested a review from a team as a code owner September 28, 2022 10:10
@magomez magomez self-assigned this Sep 28, 2022
@magomez magomez added WebKit Nightly Build WebKitGTK Bugs related to the Gtk API layer. labels Sep 28, 2022
@magomez magomez added the merge-queue Applied to send a pull request to merge-queue label Sep 29, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 254988@main (977e507): https://commits.webkit.org/254988@main

Reviewed commits have been landed. Closing PR #4787 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
4 participants