Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ews-build.webkit.org] Cache contributors by default #483

Merged
merged 0 commits into from May 4, 2022
Merged

[ews-build.webkit.org] Cache contributors by default #483

merged 0 commits into from May 4, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented May 3, 2022 •
edited by webkit-early-warning-system

c1d0ddd

[ews-build.webkit.org] Cache contributors by default
https://bugs.webkit.org/show_bug.cgi?id=240040
<rdar://problem/92695239 >

Reviewed by Aakash Jain.

On-disk contributor record can get stale quickly. Rely on the network by default.

* Tools/CISupport/ews-build/steps.py:
(GitHub.email_for_owners): Rely on the network contributors.json by default.
(Contributors.load): Force reload contributors every 4 hours. Use disk or remote if specifically
requested, otherwise default to remote. Use cache if not expired.
(ValidateCommitterAndReviewer.start): Rely on the network contributors.json by default.
(AddReviewerMixin.gitCommitEnvironment): Ditto.
(AddAuthorToCommitMessage.author): Ditto.

Canonical link: https://commits.webkit.org/250253@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this May 3, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels May 3, 2022
@JonWBedard JonWBedard requested review from aj062 and whsieh May 3, 2022 22:01
@JonWBedard JonWBedard force-pushed the eng/ews-build-webkit-org-Prefer-remote-contributors-json branch from 305fccd to fc54af0 Compare May 3, 2022 23:02
@JonWBedard JonWBedard force-pushed the eng/ews-build-webkit-org-Prefer-remote-contributors-json branch from fc54af0 to 6b8da66 Compare May 4, 2022 15:03
@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 4, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit c1d0ddd into WebKit:main May 4, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Prefer-remote-contributors-json branch from 6b8da66 to c1d0ddd Compare May 4, 2022 15:26
@webkit-early-warning-system
Copy link
Collaborator

Committed r293774 (250253@main): https://commits.webkit.org/250253@main

Reviewed commits have been landed. Closing PR #483 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 4, 2022
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Prefer-remote-contributors-json branch May 19, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj062 aj062 aj062 approved these changes

@whsieh whsieh Awaiting requested review from whsieh

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@JonWBedard @webkit-early-warning-system @aj062