Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRTC end-to-end encryption sample crash #4867

Merged
merged 1 commit into from
Sep 30, 2022
Merged

WebRTC end-to-end encryption sample crash #4867

merged 1 commit into from
Sep 30, 2022

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Sep 30, 2022 •
edited by webkit-early-warning-system

92d0f20

WebRTC end-to-end encryption sample crash
https://bugs.webkit.org/show_bug.cgi?id=245870
<rdar://100604972>

Reviewed by Geoffrey Garen.

This is caused by a syscall sandbox violation in the WebContent process.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/255036@main

4f34009

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe
✅ 🛠 ios-sim   🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim   🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@pvollan pvollan self-assigned this Sep 30, 2022
@pvollan pvollan added the WebRTC For bugs in WebRTC label Sep 30, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4f34009)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe
✅ 🛠 ios-sim   🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim   🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

geoffreygaren
geoffreygaren approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@pvollan
Copy link
Contributor Author

pvollan commented Sep 30, 2022

r=me

Thanks for reviewing!

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label Sep 30, 2022
@pvollan
WebRTC end-to-end encryption sample crash
92d0f20 
https://bugs.webkit.org/show_bug.cgi?id=245870
<rdar://100604972>

Reviewed by Geoffrey Garen.

This is caused by a syscall sandbox violation in the WebContent process.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/255036@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/WebRTC-end-to-end-encryption-sample-crash branch from 4f34009 to 92d0f20 Compare September 30, 2022 18:41
@webkit-commit-queue
Copy link
Collaborator

Committed 255036@main (92d0f20): https://commits.webkit.org/255036@main

Reviewed commits have been landed. Closing PR #4867 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 92d0f20 into WebKit:main Sep 30, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@cdumez cdumez Awaiting requested review from cdumez

@youennf youennf Awaiting requested review from youennf

@gavin-apple gavin-apple Awaiting requested review from gavin-apple

Assignees

@pvollan pvollan

Labels
WebRTC For bugs in WebRTC
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @geoffreygaren