Return from PiP to Element Fullscreen Animation breaks sometimes #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash e2d2dc6)
|
eric-carlson
approved these changes
Sep 30, 2022
jernoble
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=245890 <rdar://98839882> Reviewed by Eric Carlson. When entering picture-in-picture from "element" fullscreen (as opposed to "video" i.e. "AVKit" fullscreen) tapping the "return" button in the PiP window will re-enter fullscreen. But because this operation may take a while (re-layout of a heavy page like youtube.com can take upwards of 500ms), WebKit performs a four-part transition: 1, enter AVKit fullscreen mode with blank content; 2, exit PiP into the AVKit fullscreen presentation; 3, enter "element" fullscreen mode behind AVKit's fullscreen presentation; 4, exit AKit fullscreen _into_ the "element" fullscreen presentation. When this bug occurs, it appears that in step 3, the "element" fullscreen presentation happens _on top_ of the AVKit fullscreen presentation rather than below. To mitigate this animation issue, disable the "element" fullscreen presentation animation when transitining to fullcreen from PiP mode. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): Canonical link: https://commits.webkit.org/255041@main
webkit-early-warning-system
force-pushed
the
eng/Return-from-PiP-to-Element-Fullscreen-Animation-breaks-sometimes
branch
from
e2d2dc6
to
f235928
Compare
|
Committed 255041@main (f235928): https://commits.webkit.org/255041@main Reviewed commits have been landed. Closing PR #4873 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f235928
e2d2dc6
🛠 wpe🛠 mac-debug🧪 ios-wk2🛠 mac-AS-debug🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress