Add support for css content-visibility: hidden #4936

cathiechen · 2022-10-03T18:56:10Z

`faf9ff8`

Add support for css content-visibility: hidden
https://bugs.webkit.org/show_bug.cgi?id=236710

Reviewed by Antti Koivisto.

This patch implements support for content-visibility: hidden [1].
It introduces the fake inherited property effectiveSkipsContent to keep
track for Elements whether content-visibility is hidden and whether elements
should be skipped for painting and hit testing.

Several points in 4.3. Restrictions and Clarifications [2] are addressed too:
- scrollIntoView is adapted [4.3.5]
- tab-order navigation and focusing take skipped contents into account [3].

[1] https://drafts.csswg.org/css-contain/#using-cv-hidden
[2] https://drafts.csswg.org/css-contain/#cv-notes
[3] https://drafts.csswg.org/css-contain/#valdef-content-visibility-hidden

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-015-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-016-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-017-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-018-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-029-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-035-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-038-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-047-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-072-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-img-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-input-image-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-006-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-009-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-010-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-document-under-content-visibility-focus-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-document-under-content-visibility-gbcr-expected.txt:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::isFocusable const): skipped contents are not focusable
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::scrollRectToVisible): do not scroll if the RenderObject is skipped content
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContents): do not paint contents for c-v: hidden
* Source/WebCore/rendering/RenderElement.h:
(WebCore::RenderElement::visibleToHitTesting const): mark skipped content as not visible to hit testing
(WebCore::RenderElement::shouldApplyLayoutContainment const): c-v: hidden forces containment
(WebCore::RenderElement::shouldApplyPaintContainment const): c-v: hidden forces containment
(WebCore::RenderElement::shouldApplyLayoutOrPaintContainment const): c-v: hidden forces containment
(WebCore::RenderElement::shouldApplySizeContainment const): c-v: hidden forces containment
(WebCore::RenderElement::shouldApplyInlineSizeContainment const): c-v: hidden forces containment
(WebCore::RenderElement::shouldApplySizeOrInlineSizeContainment const): c-v: hidden forces containment
(WebCore::RenderElement::shouldApplyStyleContainment const): c-v: hidden forces containment
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList): do not paint child layers of a c-v: hidden container
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterDescendants):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::isSkippedContent const):
(WebCore::RenderObject::shouldSkipContent const):
* Source/WebCore/rendering/RenderObject.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint): do not paint contents for content-visibility: hidden
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint): do not paint contents for content-visibility: hidden
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::effectiveSkipsContent const):
(WebCore::RenderStyle::setEffectiveSkipsContent):
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):

faf9ff8

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
~~🛠 🧪 merge~~	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-03T18:56:20Z

EWS run on previous version of this PR (hash 213fc8a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

rwlbuis · 2022-10-03T20:00:39Z

Note that the patch has been reduced a lot and now has only the basics and should be easier to review. The plan is to file bugs like https://bugs.webkit.org/show_bug.cgi?id=245775 for related functionality on top of this.

webkit-early-warning-system · 2022-10-12T13:41:31Z

EWS run on previous version of this PR (hash 8ae0db5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-14T14:37:16Z

EWS run on previous version of this PR (hash c9adf21)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

anttijk · 2022-10-24T09:01:51Z

Source/WebCore/dom/Element.h

+struct ContentVisibilityData {
+    WTF_MAKE_STRUCT_FAST_ALLOCATED;
+    bool isSkippedContent { false };
+    ContentVisibility contentVisibility;
+};


If there is nothing else to put here, this doesn't really need a heap allocated struct. Those fields could just sit directly in the rare data and take less space.

Hmm, we will have more flags here for content-visibility: auto to indicate if the element is relevant to the user, something like:

bool isIntersectingViewport { false }; bool subtreeHasFocus { false }; bool subtreeHasSelection { false };

See the WIP-patch in https://bugs.webkit.org/show_bug.cgi?id=236711, looks like there isn't complex function there.
I'm fine to put isSkippedContent and contentVisibility in ElementRareData.

Hi Cathie, I think the idea was to get rid of the ContentVisibilityData completely, or at least not dynamically allocate it. Anyway I can fix this tomorrow morning.

I pushed a new version for what I think was the initial suggestion.

The failing win test has been flaky for a while so I think we can ignore it:
https://ews-build.webkit.org/#/builders/10

So this is ready for review again.

anttijk · 2022-10-24T09:13:11Z

Source/WebCore/rendering/RenderLayer.cpp

@@ -3389,7 +3389,7 @@ void RenderLayer::paintList(LayerList layerIterator, GraphicsContext& context, c
    if (layerIterator.begin() == layerIterator.end())
        return;

-    if (!hasSelfPaintingLayerDescendant())
+    if (!hasSelfPaintingLayerDescendant() || renderer().shouldSkipContent())


How is it determined where these tests are needed? It seems bit random.

The spec says "...to a large extent do not update their styles at all unless explicitly requested by script" and "user agent should additionally avoid as much layout/rendering work as possible for skipped contents" yet I see only tests about skipping painting and hit testing. This won't really help performance much. Is the plan to add those things later?

The spec also says "This is similar to giving the contents display: none". In display:none case we don't actually build a render tree at all for that subtree. Is that the intention of the spec?

OK, I'll let @rwlbuis explain this, he does most work of this feature:)

The tests are added in order to comply with the specification/tests or to make things more efficient, see also the per method comments in the commit message.

A lot of the performance comes from enabling all kinds of containment when content-visibility is hidden, we did that by adjusting shouldApply*Containment methods. But note paint containment mostly works through overflow: clip, so this patch optimises more by avoiding painting of contents/children. I agree for hit testing it may not be a big win but for correctness we have to implement that (whenever the contents are skipped).

Regarding display: none, there are a lot of similarities, and I would not be surprised that its problems was the starting point for content-visibility. Basically display: none changes are heavy while content-visibility changes should be instant ideally. I think the hint was a way to help the reader think about content-visibility: hidden. In the content-visibility case I think we do want to build the render tree, to be less costly when updating the property, and to make content-visibility: auto efficient as well.

Work on top, besides the obvious content-visibility: auto work, will be in the area of editing, resize/intersection observer, top layers/dialogs, accessibility. From the top of my head, except maybe resize/intersection observer, I think it is more about correctness/spec compliance than performance.

webkit-early-warning-system · 2022-10-24T16:48:05Z

EWS run on previous version of this PR (hash 7768000)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-28T12:22:31Z

EWS run on previous version of this PR (hash ea3d9e7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-28T15:07:37Z

EWS run on previous version of this PR (hash a11cb58)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-31T09:39:19Z

EWS run on previous version of this PR (hash 1a136ee)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

anttijk

much better!

anttijk · 2022-10-31T17:29:02Z

Source/WebCore/rendering/RenderElement.h

@@ -521,37 +524,37 @@ inline bool RenderElement::shouldApplySizeOrStyleContainment(bool containsAccord

 inline bool RenderElement::shouldApplyLayoutContainment() const
 {
-    return shouldApplyLayoutOrPaintContainment(style().containsLayout());
+    return shouldApplyLayoutOrPaintContainment(style().containsLayout() || style().contentVisibility() != ContentVisibility::Visible);


Maybe this test could be in containsLayout() function? Same for containsPaint() etc.

I prefer to keep this as-is for now. Future work on this (forced layout/content-visibility: auto) may need to change/extend these code sections and it is not quite clear yet how.

anttijk · 2022-10-31T17:30:16Z

Source/WebCore/rendering/RenderObject.cpp

@@ -2553,6 +2553,16 @@ String RenderObject::debugDescription() const
    return builder.toString();
 }

+bool RenderObject::isSkippedContent() const
+{
+    return style().isInSkippedContentSubtree() && parent() && parent()->style().isInSkippedContentSubtree();


I think it is sufficient to test the parent bit only (render is skipped if the parent is skipping the content)

Nice thanks!

anttijk · 2022-10-31T17:41:01Z

Source/WebCore/rendering/style/RenderStyle.h

@@ -550,6 +550,8 @@ class RenderStyle {

    ContentVisibility contentVisibility() const { return static_cast<ContentVisibility>(m_rareNonInheritedData->contentVisibility); }

+    bool isInSkippedContentSubtree() const { return m_rareInheritedData->isInSkippedContentSubtree; }


Something like effectiveSkipsContent might be less clunky and communicate that this is an effective property (similar to others).

https://bugs.webkit.org/show_bug.cgi?id=236710 Reviewed by Antti Koivisto. This patch implements support for content-visibility: hidden [1]. It introduces the fake inherited property effectiveSkipsContent to keep track for Elements whether content-visibility is hidden and whether elements should be skipped for painting and hit testing. Several points in 4.3. Restrictions and Clarifications [2] are addressed too: - scrollIntoView is adapted [4.3.5] - tab-order navigation and focusing take skipped contents into account [3]. [1] https://drafts.csswg.org/css-contain/#using-cv-hidden [2] https://drafts.csswg.org/css-contain/#cv-notes [3] https://drafts.csswg.org/css-contain/#valdef-content-visibility-hidden * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-015-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-016-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-017-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-018-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-029-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-035-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-038-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-047-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-072-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-img-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-input-image-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-006-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-009-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/auto-010-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-document-under-content-visibility-focus-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-document-under-content-visibility-gbcr-expected.txt: * Source/WebCore/dom/Element.cpp: (WebCore::Element::isFocusable const): skipped contents are not focusable * Source/WebCore/page/FrameView.cpp: (WebCore::FrameView::scrollRectToVisible): do not scroll if the RenderObject is skipped content * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents): do not paint contents for c-v: hidden * Source/WebCore/rendering/RenderElement.h: (WebCore::RenderElement::visibleToHitTesting const): mark skipped content as not visible to hit testing (WebCore::RenderElement::shouldApplyLayoutContainment const): c-v: hidden forces containment (WebCore::RenderElement::shouldApplyPaintContainment const): c-v: hidden forces containment (WebCore::RenderElement::shouldApplyLayoutOrPaintContainment const): c-v: hidden forces containment (WebCore::RenderElement::shouldApplySizeContainment const): c-v: hidden forces containment (WebCore::RenderElement::shouldApplyInlineSizeContainment const): c-v: hidden forces containment (WebCore::RenderElement::shouldApplySizeOrInlineSizeContainment const): c-v: hidden forces containment (WebCore::RenderElement::shouldApplyStyleContainment const): c-v: hidden forces containment * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintList): do not paint child layers of a c-v: hidden container * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterDescendants): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::isSkippedContent const): (WebCore::RenderObject::shouldSkipContent const): * Source/WebCore/rendering/RenderObject.h: * Source/WebCore/rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): do not paint contents for content-visibility: hidden * Source/WebCore/rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): do not paint contents for content-visibility: hidden * Source/WebCore/rendering/style/RenderStyle.h: (WebCore::RenderStyle::effectiveSkipsContent const): (WebCore::RenderStyle::setEffectiveSkipsContent): * Source/WebCore/rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * Source/WebCore/rendering/style/StyleRareInheritedData.h: * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const):

webkit-early-warning-system · 2022-11-01T10:08:07Z

EWS run on current version of this PR (hash faf9ff8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
~~🛠 🧪 merge~~	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

rwlbuis · 2022-11-01T10:55:16Z

This system gets confused about multiple people working on a PR, and git-webkit was not able to make me owner of this PR. So I will use good old bugzilla.

rwlbuis · 2022-11-01T14:48:37Z

This landed as r256186.

cathiechen requested review from cdumez and rniwa as code owners October 3, 2022 18:56

cathiechen self-assigned this Oct 3, 2022

cathiechen added CSS Cascading Style Sheets implementation WebKit Local Build labels Oct 3, 2022

rwlbuis requested review from darinadler and smfr and removed request for rniwa and cdumez October 3, 2022 19:52

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 4, 2022

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label Oct 12, 2022

rwlbuis force-pushed the content-visibility-hidden-split-001 branch from 213fc8a to 8ae0db5 Compare October 12, 2022 13:41

rwlbuis self-assigned this Oct 12, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 12, 2022

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

rwlbuis force-pushed the content-visibility-hidden-split-001 branch from 8ae0db5 to c9adf21 Compare October 14, 2022 14:34

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

anttijk reviewed Oct 24, 2022

View reviewed changes

cathiechen closed this Oct 24, 2022

cathiechen force-pushed the content-visibility-hidden-split-001 branch from c9adf21 to bc9fcf4 Compare October 24, 2022 16:35

cathiechen removed the merging-blocked Applied to prevent a change from being merged label Oct 24, 2022

cathiechen reopened this Oct 24, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 24, 2022

cathiechen removed the merging-blocked Applied to prevent a change from being merged label Oct 24, 2022

cathiechen force-pushed the content-visibility-hidden-split-001 branch from 7768000 to d640921 Compare October 24, 2022 18:13

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

rwlbuis force-pushed the content-visibility-hidden-split-001 branch from 815a829 to ea3d9e7 Compare October 28, 2022 12:21

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

rwlbuis force-pushed the content-visibility-hidden-split-001 branch from ea3d9e7 to a11cb58 Compare October 28, 2022 15:07

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label Oct 31, 2022

rwlbuis force-pushed the content-visibility-hidden-split-001 branch from a11cb58 to 1a136ee Compare October 31, 2022 09:38

anttijk approved these changes Oct 31, 2022

View reviewed changes

rwlbuis force-pushed the content-visibility-hidden-split-001 branch from 1a136ee to faf9ff8 Compare November 1, 2022 10:05

cathiechen removed their assignment Nov 1, 2022

cathiechen added the merge-queue Applied to send a pull request to merge-queue label Nov 1, 2022

cathiechen removed the merge-queue Applied to send a pull request to merge-queue label Nov 1, 2022

webkit-commit-queue added the merging-blocked Applied to prevent a change from being merged label Nov 1, 2022

darinadler closed this Nov 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for css content-visibility: hidden #4936

Add support for css content-visibility: hidden #4936

cathiechen commented Oct 3, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Oct 3, 2022 •

edited

rwlbuis commented Oct 3, 2022

webkit-early-warning-system commented Oct 12, 2022 •

edited

webkit-early-warning-system commented Oct 14, 2022 •

edited

anttijk Oct 24, 2022

cathiechen Oct 24, 2022

rwlbuis Oct 24, 2022

rwlbuis Oct 25, 2022

rwlbuis Oct 27, 2022

anttijk Oct 24, 2022

cathiechen Oct 24, 2022

rwlbuis Oct 25, 2022 •

edited

webkit-early-warning-system commented Oct 24, 2022 •

edited

webkit-early-warning-system commented Oct 28, 2022 •

edited

webkit-early-warning-system commented Oct 28, 2022 •

edited

webkit-early-warning-system commented Oct 31, 2022 •

edited

anttijk left a comment

anttijk Oct 31, 2022

rwlbuis Nov 1, 2022

anttijk Oct 31, 2022 •

edited

rwlbuis Nov 1, 2022

anttijk Oct 31, 2022

rwlbuis Nov 1, 2022

webkit-early-warning-system commented Nov 1, 2022 •

edited

rwlbuis commented Nov 1, 2022

rwlbuis commented Nov 1, 2022

		@@ -550,6 +550,8 @@ class RenderStyle {

		ContentVisibility contentVisibility() const { return static_cast<ContentVisibility>(m_rareNonInheritedData->contentVisibility); }

		bool isInSkippedContentSubtree() const { return m_rareInheritedData->isInSkippedContentSubtree; }

Add support for css content-visibility: hidden #4936

Add support for css content-visibility: hidden #4936

Conversation

cathiechen commented Oct 3, 2022 • edited by webkit-early-warning-system

webkit-early-warning-system commented Oct 3, 2022 • edited

rwlbuis commented Oct 3, 2022

webkit-early-warning-system commented Oct 12, 2022 • edited

webkit-early-warning-system commented Oct 14, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwlbuis Oct 25, 2022 • edited

Choose a reason for hiding this comment

webkit-early-warning-system commented Oct 24, 2022 • edited

webkit-early-warning-system commented Oct 28, 2022 • edited

webkit-early-warning-system commented Oct 28, 2022 • edited

webkit-early-warning-system commented Oct 31, 2022 • edited

anttijk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anttijk Oct 31, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Nov 1, 2022 • edited

rwlbuis commented Nov 1, 2022

rwlbuis commented Nov 1, 2022

cathiechen commented Oct 3, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Oct 3, 2022 •

edited

webkit-early-warning-system commented Oct 12, 2022 •

edited

webkit-early-warning-system commented Oct 14, 2022 •

edited

rwlbuis Oct 25, 2022 •

edited

webkit-early-warning-system commented Oct 24, 2022 •

edited

webkit-early-warning-system commented Oct 28, 2022 •

edited

webkit-early-warning-system commented Oct 28, 2022 •

edited

webkit-early-warning-system commented Oct 31, 2022 •

edited

anttijk Oct 31, 2022 •

edited

webkit-early-warning-system commented Nov 1, 2022 •

edited