Allow font-variant east-asian shorthand in any position #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdubet
added
WebCore Misc.
|
EWS run on previous version of this PR (hash f324eff) |
mdubet
force-pushed
the
font-variant-east-asian-bug-245972
branch
from
f324eff
to
efb7837
Compare
|
EWS run on previous version of this PR (hash efb7837) |
mdubet
force-pushed
the
font-variant-east-asian-bug-245972
branch
from
efb7837
to
c12e3b1
Compare
mdubet
changed the title
|
EWS run on previous version of this PR (hash c12e3b1)
|
darinadler
approved these changes
Oct 3, 2022
webkit-ews-buildbot
added
the
merging-blocked
nt1m
reviewed
Oct 4, 2022
There was a problem hiding this comment.
I'm wondering if font-variant-east-asian: full-width garbage or font-variant-east-asian: full-width none is correctly handled here. We've had a similar bug with the list-style shorthand, where it supported list-style: none garbage because it didn't do a proper range end check.
mdubet
force-pushed
the
font-variant-east-asian-bug-245972
branch
from
c12e3b1
to
8d4b6dd
Compare
|
EWS run on previous version of this PR (hash 8d4b6dd)
|
nt1m
reviewed
Oct 4, 2022
mdubet
force-pushed
the
font-variant-east-asian-bug-245972
branch
from
8d4b6dd
to
2123600
Compare
|
EWS run on current version of this PR (hash 2123600)
|
https://bugs.webkit.org/show_bug.cgi?id=245972 Reviewed by Darin Adler. The property font-variant-east-asian can be used in any position in the font-variant shorthand ; it should not check that the range is finished. https://drafts.csswg.org/css-fonts-4/#font-variant-prop * LayoutTests/fast/text/font-variant-shorthand-expected.txt: * LayoutTests/fast/text/font-variant-shorthand.html: Add tests which fail before this change. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-east-asian-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-east-asian-invalid.html: Imported from WPT. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-valid-expected.txt: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontVariantEastAsian): Canonical link: https://commits.webkit.org/255134@main
webkit-commit-queue
force-pushed
the
font-variant-east-asian-bug-245972
branch
from
2123600
to
fd7b349
Compare
|
Committed 255134@main (fd7b349): https://commits.webkit.org/255134@main Reviewed commits have been landed. Closing PR #4945 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd7b349
2123600
🛠 🧪 win🛠 mac-debug🧪 ios-wk2🛠 mac-AS-debug🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress