New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LBSE] Fix SVGImage container size propagation #4995
[LBSE] Fix SVGImage container size propagation #4995
Conversation
EWS run on previous version of this PR (hash 87ce771) |
This needs a rebase once PR #4998 is in. |
87ce771
to
2968f38
Compare
EWS run on previous version of this PR (hash 2968f38) |
2968f38
to
e35a4bb
Compare
Rebased. Can you have a look @rwlbuis? |
EWS run on current version of this PR (hash e35a4bb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
https://bugs.webkit.org/show_bug.cgi?id=246034 Reviewed by Rob Buis. Propagate container size in SVGImage also for RenderSVGRoot, not only LegacyRenderSVGRoot. This requires to enable SVGImage to actually use LBSE for its documents, if the host document has LBSE turned on. This requires plumbing the 'layerBasedSVGEngineEnabled' flag from Settings (reachable via Document) down to CachedImage / ImageObserver so that we can set the flag, if necessary, before constructing the document from the network data. Otherwise SVGImage in LBSE will continue to use the legacy SVG engine. Update TestExpectations now that SVGImage uses LBSE as well. * LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/as-background-image/svg-as-background-6-expected.png: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/as-image/svg-non-integer-scaled-image-expected.png: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/zoom/page/zoom-background-images-expected.png: Added. * Source/WebCore/loader/cache/CachedImage.cpp: (WebCore::CachedImage::load): * Source/WebCore/loader/cache/CachedImage.h: * Source/WebCore/platform/graphics/ImageObserver.h: (WebCore::ImageObserver::layerBasedSVGEngineEnabled const): * Source/WebCore/svg/graphics/SVGImage.cpp: (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::containerSize const): (WebCore::SVGImage::dataChanged): Canonical link: https://commits.webkit.org/255625@main
e35a4bb
to
3c9c020
Compare
Committed 255625@main (3c9c020): https://commits.webkit.org/255625@main Reviewed commits have been landed. Closing PR #4995 and removing active labels. |
3c9c020
e35a4bb
π π§ͺ winπ§ͺ api-ios