Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some user-specific data from WebKitTestRunner.xcscheme #5007

Merged
merged 1 commit into from Oct 5, 2022
Merged

Remove some user-specific data from WebKitTestRunner.xcscheme #5007

merged 1 commit into from Oct 5, 2022

Conversation

smfr
Copy link
Contributor

@smfr smfr commented Oct 5, 2022 •
edited by webkit-early-warning-system

549739f

Remove some user-specific data from WebKitTestRunner.xcscheme
https://bugs.webkit.org/show_bug.cgi?id=246054
rdar://100788135

Reviewed by Tim Horton and Jonathan Bedard.

Some data in WebKitTestRunner.xcscheme was checked in by mistake.

* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme:

Canonical link: https://commits.webkit.org/255176@main

eb2fd61

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@smfr smfr requested a review from JonWBedard as a code owner October 5, 2022 00:21
@smfr smfr self-assigned this Oct 5, 2022
@smfr smfr added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Oct 5, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash eb2fd61)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@smfr smfr requested a review from jernoble October 5, 2022 00:22
@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label Oct 5, 2022
@smfr
Remove some user-specific data from WebKitTestRunner.xcscheme
549739f 
https://bugs.webkit.org/show_bug.cgi?id=246054
rdar://100788135

Reviewed by Tim Horton and Jonathan Bedard.

Some data in WebKitTestRunner.xcscheme was checked in by mistake.

* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme:

Canonical link: https://commits.webkit.org/255176@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Remove-some-user-specific-data-from-WebKitTestRunner-xcscheme branch from eb2fd61 to 549739f Compare October 5, 2022 17:02
@webkit-commit-queue
Copy link
Collaborator

Committed 255176@main (549739f): https://commits.webkit.org/255176@main

Reviewed commits have been landed. Closing PR #5007 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 549739f into WebKit:main Oct 5, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@JonWBedard JonWBedard JonWBedard approved these changes

@jernoble jernoble Awaiting requested review from jernoble

Assignees

@smfr smfr

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@smfr @webkit-early-warning-system @webkit-commit-queue @hortont424 @JonWBedard