Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple details to my contributors.json entry #5024

Closed
wants to merge 1 commit into from

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Oct 5, 2022

Pull Request Template

File a Bug

All changes should be associated with a bug. The WebKit project is currently using Bugzilla as our bug tracker. Note that multiple changes may be associated with a single bug.

Provided Tooling

The WebKit Project strongly recommends contributors use Tools/Scripts/git-webkit to generate pull requests. See Setup and Contributing Code for how to do this.

Template

If a contributor wishes to file a pull request manually, the template is below. Manually-filed pull requests should contain their commit message as the pull request description, and their commit message should be formatted like the template below.

Additionally, the pull request should be mentioned on Bugzilla, labels applied to the pull request matching the component and version of the Bugzilla associated with the pull request and the pull request assigned to its author.

Add a couple details to my contributors.json entry
https://bugs.webkit.org/show_bug.cgi?id=246077

Reviewed by NOBODY (OOPS!).

* metadata/contributors.json

768241d

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@cdumez
Copy link
Contributor

cdumez commented Oct 5, 2022

I suspect this PR wasn't made using git-webkit pr given the template issues.

@JonWBedard
Copy link
Member

Your commit message does need to say something about the review, otherwise merge-queue will reject it. You either need Reviewed by NOBODY (OOPS!). which will be replaced by the reviewer, or something like Unreviewed contributors.json update (since we're generally OK landing changes to contributors.json unreviewed)

@annevk
Copy link
Contributor Author

annevk commented Oct 10, 2022

I tried to reuse this branch, but git-webkit pr didn't pick it up and it created #5186. I thought it was going to help me with the commit message, but that was a bit naΓ―ve. I'll see about fixing that and hopefully it won't create even more PRs.

@annevk annevk closed this Oct 10, 2022
@annevk annevk deleted the patch-1 branch October 10, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants