Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add myself (Youssef Soliman) to contributors.json #505

Merged
merged 0 commits into from May 5, 2022
Merged

Add myself (Youssef Soliman) to contributors.json #505

merged 0 commits into from May 5, 2022

Conversation

youssefsoli
Copy link
Contributor

@youssefsoli youssefsoli commented May 4, 2022 •
edited by webkit-early-warning-system

ba875c0

Add myself (Youssef Soliman) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240084

Reviewed by Jer Noble.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/250279@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@jernoble
Copy link
Contributor

jernoble commented May 4, 2022

r=me

@eric-carlson eric-carlson added the merge-queue Applied to send a pull request to merge-queue label May 4, 2022
jernoble
jernoble approved these changes May 4, 2022
View reviewed changes
metadata/contributors.json Outdated
"ys",
"youssefsoli"
],
"status" : "committer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should omit this line. You're not quite a committer yet.

@eric-carlson eric-carlson removed the merge-queue Applied to send a pull request to merge-queue label May 4, 2022
@JonWBedard
Copy link
Member

As Merge-Queue warned, commits need to be squashed before landing.

@JonWBedard
Copy link
Member

The recently added commit looks like a merge-commit. What you want to do is reset your head with git reset HEAD~3 and then re-commit this change.

@youssefsoli youssefsoli force-pushed the eng/Add-myself-Youssef-Soliman-to-contributors-json branch from 6e3d8a5 to d601489 Compare May 5, 2022 00:04
@youssefsoli
Copy link
Contributor Author

Figured it out finally (I hope)

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 5, 2022
@JonWBedard
Copy link
Member

Figured it out finally (I hope)

Looks good, sending through merge-queue now

@webkit-early-warning-system webkit-early-warning-system merged commit ba875c0 into WebKit:main May 5, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r293806 (250279@main): https://commits.webkit.org/250279@main

Reviewed commits have been landed. Closing PR #505 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Add-myself-Youssef-Soliman-to-contributors-json branch from d601489 to ba875c0 Compare May 5, 2022 00:21
@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 5, 2022
@youssefsoli youssefsoli deleted the eng/Add-myself-Youssef-Soliman-to-contributors-json branch May 5, 2022 00:23
@youssefsoli youssefsoli restored the eng/Add-myself-Youssef-Soliman-to-contributors-json branch May 5, 2022 02:19
@youssefsoli youssefsoli self-assigned this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jernoble jernoble jernoble approved these changes

Assignees

@youssefsoli youssefsoli

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@youssefsoli @jernoble @JonWBedard @webkit-early-warning-system @eric-carlson