Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSC] Update Intl.NumberFormat's useGrouping handling #5123

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Oct 7, 2022

4a7ae87

[JSC] Update Intl.NumberFormat's useGrouping handling
https://bugs.webkit.org/show_bug.cgi?id=246196
rdar://100877842

Reviewed by Ross Kirsling.

Update the implementation with the spec update[1], handling "true" and "false"
specially and throwing a range error for the other invalid cases.

[1]: tc39/proposal-intl-numberformat-v3@4751da5

* JSTests/stress/intl-numberformat-usegrouping-v3.js:
(nonListedUseGrouping.forEach):
(specialUseGrouping.forEach):
* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::initializeNumberFormat):
* Source/JavaScriptCore/runtime/IntlObjectInlines.h:
(JSC::intlStringOrBooleanOption):

Canonical link: https://commits.webkit.org/255275@main

1ac6bed

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe ❌ πŸ›  πŸ§ͺ win
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios   πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch   πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner October 7, 2022 00:51
@Constellation Constellation self-assigned this Oct 7, 2022
@Constellation Constellation added JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. WebKit Nightly Build labels Oct 7, 2022
Copy link
Member

@rkirsling rkirsling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the current spec state.

@Constellation Constellation added the merge-queue Applied to send a pull request to merge-queue label Oct 7, 2022
https://bugs.webkit.org/show_bug.cgi?id=246196
rdar://100877842

Reviewed by Ross Kirsling.

Update the implementation with the spec update[1], handling "true" and "false"
specially and throwing a range error for the other invalid cases.

[1]: tc39/proposal-intl-numberformat-v3@4751da5

* JSTests/stress/intl-numberformat-usegrouping-v3.js:
(nonListedUseGrouping.forEach):
(specialUseGrouping.forEach):
* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::initializeNumberFormat):
* Source/JavaScriptCore/runtime/IntlObjectInlines.h:
(JSC::intlStringOrBooleanOption):

Canonical link: https://commits.webkit.org/255275@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/JSC-Update-Intl-NumberFormats-useGrouping-handling branch from 1ac6bed to 4a7ae87 Compare October 7, 2022 16:41
@webkit-commit-queue
Copy link
Collaborator

Committed 255275@main (4a7ae87): https://commits.webkit.org/255275@main

Reviewed commits have been landed. Closing PR #5123 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 4a7ae87 into WebKit:main Oct 7, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
4 participants