Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Live Range Selection] hidden-textarea-selection-quirk.html fails #5213

Closed
wants to merge 0 commits into from

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Oct 10, 2022

f5fde80

[Live Range Selection] hidden-textarea-selection-quirk.html fails
https://bugs.webkit.org/show_bug.cgi?id=246309

Reviewed by Darin Adler.

The issue was caused by Selection's toString() function no longer containing the content to be copied.

Fixed the test by actually triggering copying & pasting text and checking the pasted content
instead of assuming that Selection's toString() function returns the content to be copied.

* LayoutTests/editing/text-iterator/hidden-textarea-selection-quirk.html:

Canonical link: https://commits.webkit.org/255385@main

6ff6460

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  πŸ§ͺ win
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@rniwa rniwa self-assigned this Oct 10, 2022
@rniwa rniwa added HTML Editing For bugs in HTML editing support (including designMode and contentEditable). WebKit Nightly Build labels Oct 10, 2022
@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 11, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 255385@main (f5fde80): https://commits.webkit.org/255385@main

Reviewed commits have been landed. Closing PR #5213 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 11, 2022
@rniwa rniwa deleted the fix246309 branch October 11, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTML Editing For bugs in HTML editing support (including designMode and contentEditable).
Projects
None yet
4 participants