New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Live Range Selection] Some tests fail due to ApplyStyleCommand not canonicalizing ending selection #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
HTML Editing
For bugs in HTML editing support (including designMode and contentEditable).
WebKit Nightly Build
labels
Oct 11, 2022
EWS run on previous version of this PR (hash 2ae6983) |
darinadler
approved these changes
Oct 11, 2022
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Oct 11, 2022
EWS run on current version of this PR (hash 19ab7f8) |
rniwa
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Oct 11, 2022
β¦anonicalizing ending selection https://bugs.webkit.org/show_bug.cgi?id=246314 Reviewed by Darin Adler. Explicitly canonicalize positions in ApplyStyleCommand::updateStartEnd so that enabling live range selection do not cause a new test failure. Also add variants of the tests that used to fail without this patch. * LayoutTests/editing/execCommand/remove-format-background-color-live-range-expected.txt: Added. * LayoutTests/editing/execCommand/remove-format-background-color-live-range.html: Added. * LayoutTests/editing/execCommand/remove-format-image-live-range-expected.txt: Added. * LayoutTests/editing/execCommand/remove-format-image-live-range.html: Added. * LayoutTests/editing/execCommand/remove-format-in-table-cell-live-range-expected.txt: Added. * LayoutTests/editing/execCommand/remove-format-in-table-cell-live-range.html: Added. * LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe-live-range-expected.txt: Added. * LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe-live-range.html: Added. * LayoutTests/editing/execCommand/remove-formatting-2-live-range-expected.txt: Added. * LayoutTests/editing/execCommand/remove-formatting-2-live-range.html: Added. * LayoutTests/editing/execCommand/remove-formatting-live-range-expected.txt: Added. * LayoutTests/editing/execCommand/remove-formatting-live-range.html: Added. * LayoutTests/editing/style/apply-font-size-to-multiple-nodes-live-range-expected.txt: Added. * LayoutTests/editing/style/apply-font-size-to-multiple-nodes-live-range.html: Added. * LayoutTests/editing/style/apply-style-atomic-live-range-expected.txt: Added. * LayoutTests/editing/style/apply-style-atomic-live-range.html: Added. * LayoutTests/editing/style/invalid-font-size-live-range-expected.txt: Added. * LayoutTests/editing/style/invalid-font-size-live-range.html: Added. * LayoutTests/editing/style/remove-styled-element-with-style-span-live-range-expected.txt: Added. * LayoutTests/editing/style/remove-styled-element-with-style-span-live-range.html: Added. * LayoutTests/editing/undo/redo-split-text-node-live-range-expected.txt: Added. * LayoutTests/editing/undo/redo-split-text-node-live-range.html: Added. * LayoutTests/platform/ios/editing/execCommand/remove-formatting-2-live-range-expected.txt: Added. * Source/WebCore/editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::updateStartEnd): Canonical link: https://commits.webkit.org/255409@main
webkit-commit-queue
force-pushed
the
fix246314
branch
from
October 11, 2022 22:00
19ab7f8
to
75277ce
Compare
Committed 255409@main (75277ce): https://commits.webkit.org/255409@main Reviewed commits have been landed. Closing PR #5221 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
75277ce
19ab7f8
π π§ͺ winπ§ͺ api-iosπ§ͺ api-macπ§ͺ api-gtkπ§ͺ mac-wk1π§ͺ mac-AS-debug-wk2