Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix !ENABLE(ACCESSIBILITY) build after 255279@main #5246

Merged
merged 1 commit into from Oct 11, 2022
Merged

Fix !ENABLE(ACCESSIBILITY) build after 255279@main #5246

merged 1 commit into from Oct 11, 2022

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Oct 11, 2022 •
edited by webkit-early-warning-system

6db040e

Fix !ENABLE(ACCESSIBILITY) build after 255279@main
https://bugs.webkit.org/show_bug.cgi?id=246362

Unreviewed build fix.

Add an implementation of AXObjectCache::onSelectedChanged for
`!ENABLE(ACCESSIBILITY)`.

* Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/255405@main

a43e0ae

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim   🧪 mac-wk2
✅ 🛠 watch   🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim   🧪 mac-wk2-stress

@donny-dont donny-dont self-assigned this Oct 11, 2022
@donny-dont donny-dont added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Oct 11, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a43e0ae)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim   🧪 mac-wk2
✅ 🛠 watch   🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim   🧪 mac-wk2-stress

@donny-dont donny-dont added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 11, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Fix-ENABLEACCESSIBILITY-build-after-255279main branch from a43e0ae to c42c011 Compare October 11, 2022 21:28
@donny-dont
Fix !ENABLE(ACCESSIBILITY) build after 255279@main
6db040e 
https://bugs.webkit.org/show_bug.cgi?id=246362

Unreviewed build fix.

Add an implementation of AXObjectCache::onSelectedChanged for
`!ENABLE(ACCESSIBILITY)`.

* Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/255405@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Fix-ENABLEACCESSIBILITY-build-after-255279main branch from c42c011 to 6db040e Compare October 11, 2022 21:30
@webkit-commit-queue
Copy link
Collaborator

Committed 255405@main (6db040e): https://commits.webkit.org/255405@main

Reviewed commits have been landed. Closing PR #5246 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 6db040e into WebKit:main Oct 11, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 11, 2022
@ThomasDevoogdt
Copy link
Contributor 

/home/thomas/buildroot/output/build/webkitgtk-2.38.1/Source/WebCore/accessibility/AXObjectCache.h:641:13: error: no declaration matches ‘void WebCore::AXObjectCache::onSelectedChanged(WebCore::Node*)’
 inline void AXObjectCache::onSelectedChanged(Node*) { }
             ^~~~~~~~~~~~~

Still have problems related to this. Seen on webkitgtk-2.38.1. (commit was cherry-picked: 1b18098)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@donny-dont donny-dont

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@donny-dont @webkit-early-warning-system @webkit-commit-queue @ThomasDevoogdt