Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up temporary timer-based displayDidRefresh in RemoteLayerTreeDrawingAreaProxyMac #5386

Conversation

smfr
Copy link
Contributor

@smfr smfr commented Oct 14, 2022

78ad3a8

Hook up temporary timer-based displayDidRefresh in RemoteLayerTreeDrawingAreaProxyMac
https://bugs.webkit.org/show_bug.cgi?id=246531
<rdar://problem/101182095>

Reviewed by Tim Horton.

Hook up a timer in RemoteLayerTreeDrawingAreaProxyMac to drive display refresh as an
interim solution until DisplayLink is hooked up.

* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h:
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::RemoteLayerTreeDrawingAreaProxyMac):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::scheduleDisplayLink):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::pauseDisplayLink):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::displayLinkTimerFired):

Canonical link: https://commits.webkit.org/255547@main

cd32ce1

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios   πŸ›  mac   πŸ›  wpe
βœ… πŸ›  ios-sim   πŸ›  mac-debug   πŸ›  gtk   πŸ›  wincairo
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ›  mac-AS-debug   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ api-mac   πŸ§ͺ api-gtk
  πŸ›  tv   πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim   πŸ§ͺ mac-wk2
βœ… πŸ›  watch   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim   πŸ§ͺ mac-wk2-stress

@smfr smfr requested a review from cdumez as a code owner October 14, 2022 19:24
@smfr smfr self-assigned this Oct 14, 2022
@smfr smfr added Safari Technology Preview WebKit Process Model Bugs related to WebKit's multi-process architecture labels Oct 14, 2022
@smfr smfr added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 14, 2022
…wingAreaProxyMac

https://bugs.webkit.org/show_bug.cgi?id=246531
<rdar://problem/101182095>

Reviewed by Tim Horton.

Hook up a timer in RemoteLayerTreeDrawingAreaProxyMac to drive display refresh as an
interim solution until DisplayLink is hooked up.

* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h:
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::RemoteLayerTreeDrawingAreaProxyMac):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::scheduleDisplayLink):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::pauseDisplayLink):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::displayLinkTimerFired):

Canonical link: https://commits.webkit.org/255547@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Hook-up-temporary-timer-based-displayDidRefresh-in-RemoteLayerTreeDrawingAreaProxyMac branch from cd32ce1 to 78ad3a8 Compare October 14, 2022 20:08
@webkit-commit-queue
Copy link
Collaborator

Committed 255547@main (78ad3a8): https://commits.webkit.org/255547@main

Reviewed commits have been landed. Closing PR #5386 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 78ad3a8 into WebKit:main Oct 14, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
4 participants