Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make readArrayBufferViewImpl defensive #539

Merged
merged 0 commits into from May 6, 2022
Merged

Make readArrayBufferViewImpl defensive #539

merged 0 commits into from May 6, 2022

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented May 6, 2022 •
edited by webkit-early-warning-system

c750eeb

Make readArrayBufferViewImpl defensive
https://bugs.webkit.org/show_bug.cgi?id=240154
rdar://92113248

Reviewed by Mark Lam.

Check deserialized value's type before starting using it as JSArrayBuffer*.

* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readArrayBufferViewImpl):

Canonical link: https://commits.webkit.org/250342@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@Constellation Constellation self-assigned this May 6, 2022
@Constellation Constellation added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels May 6, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 6, 2022
@Constellation Constellation removed merging-blocked Applied to prevent a change from being merged New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels May 6, 2022
@Constellation Constellation added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels May 6, 2022
MenloDorian
MenloDorian approved these changes May 6, 2022
View reviewed changes
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the merge-queue Applied to send a pull request to merge-queue label May 6, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit c750eeb into WebKit:main May 6, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r293884 (250342@main): https://commits.webkit.org/250342@main

Reviewed commits have been landed. Closing PR #539 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 6, 2022
@Constellation Constellation deleted the eng/clone-deserializer branch May 6, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MenloDorian MenloDorian MenloDorian approved these changes

Assignees

@Constellation Constellation

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
3 participants
@Constellation @webkit-early-warning-system @MenloDorian