Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space and make GitHub icons work in dark mode on webkit.org/team/ #5413

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions Websites/webkit.org/wp-content/themes/webkit/team.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
--expertise-shadow: 0px 5px 10px 0px hsla(0, 0%, 100%, 0.1);
--hover-text-color: hsl(0, 0%, 100%);
}
img.github {
filter: invert(100%);
}
}

article ul {
list-style: none;
padding-left: 0;
Expand Down Expand Up @@ -87,7 +91,6 @@
}

}

</style>
<?php if (have_posts()) : while (have_posts()) : the_post(); ?>

Expand Down Expand Up @@ -206,8 +209,9 @@ function addElement(container, tagName, attributes, text = "") {
function populateContributorListItem(listItem, contributor) {
addElement(listItem, 'strong', {'class': 'name'}, contributor.name);
if (contributor.github) {
addText(listItem, ' ');
addElement(listItem, 'a', {'href': 'https://github.com/' + contributor.github });
addElement(listItem.lastChild, 'img', {'src': 'https://raw.githubusercontent.com/primer/octicons/main/icons/mark-github-16.svg', 'width': '16', 'height': '16', 'alt': contributor.github});
addElement(listItem.lastChild, 'img', {'src': 'https://raw.githubusercontent.com/primer/octicons/main/icons/mark-github-16.svg', 'width': '16', 'height': '16', 'alt': contributor.github, 'class': 'github'});
}
if (contributor.nicks) {
addElement(listItem, 'span', {'class': 'nicks'}, ' (' + contributor.nicks.join(', ') + ')');
Expand Down