Move BuilderState::createFilterOperations() to a separate file #5479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shallawa
added
Layout and Rendering
|
EWS run on previous version of this PR (hash 95331ac)
|
webkit-ews-buildbot
added
the
merging-blocked
shallawa
removed
the
merging-blocked
shallawa
force-pushed
the
eng/Move-BuilderStatecreateFilterOperations-to-a-separate-file
branch
from
95331ac
to
5d32e99
Compare
|
EWS run on previous version of this PR (hash 5d32e99)
|
🛠 🧪 win
anttijk
approved these changes
Oct 18, 2022
Comment on lines
+28
to
+29
| namespace WebCore { | ||
|
|
There was a problem hiding this comment.
This should go to Style namespace
Comment on lines
33
to
35
| namespace Style { | ||
| enum class ForVisitedLink : bool; | ||
| } |
There was a problem hiding this comment.
Everything should be in Style namespace
Comment on lines
+35
to
+37
| namespace WebCore { | ||
|
|
| #include "StyleBuilderState.h" | ||
| #include "StyleColor.h" | ||
|
|
||
| namespace WebCore { |
There was a problem hiding this comment.
This should be in WebCore::Style namespace
shallawa
force-pushed
the
eng/Move-BuilderStatecreateFilterOperations-to-a-separate-file
branch
from
5d32e99
to
fb7622f
Compare
shallawa
added
Canvas
|
EWS run on current version of this PR (hash fb7622f)
|
https://bugs.webkit.org/show_bug.cgi?id=246675 Reviewed by Antti Koivisto. Make this function a stand-alone function and make used by the CSS style builder. The plan is to use this function the 2D canvas for the filter API. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSFilterImageValue.cpp: (WebCore::CSSFilterImageValue::createFilterOperations): * Source/WebCore/style/ColorFromPrimitiveValue.cpp: Added. (WebCore::colorFromPrimitiveValue): (WebCore::colorFromPrimitiveValueWithResolvedCurrentColor): * Source/WebCore/style/ColorFromPrimitiveValue.h: Added. * Source/WebCore/style/FilterOperationsBuilder.cpp: Added. (WebCore::filterOperationForType): (WebCore::createFilterOperations): * Source/WebCore/style/FilterOperationsBuilder.h: Added. * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertFilterOperations): * Source/WebCore/style/StyleBuilderState.cpp: (WebCore::Style::BuilderState::createFilterOperations): (WebCore::Style::BuilderState::colorFromPrimitiveValue const): (WebCore::Style::BuilderState::colorFromPrimitiveValueWithResolvedCurrentColor const): (WebCore::Style::filterOperationForType): Deleted. * Source/WebCore/style/StyleBuilderState.h: Canonical link: https://commits.webkit.org/255706@main
webkit-early-warning-system
force-pushed
the
eng/Move-BuilderStatecreateFilterOperations-to-a-separate-file
branch
from
fb7622f
to
ea05e83
Compare
|
Committed 255706@main (ea05e83): https://commits.webkit.org/255706@main Reviewed commits have been landed. Closing PR #5479 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
shallawa
deleted the
eng/Move-BuilderStatecreateFilterOperations-to-a-separate-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ea05e83
fb7622f
🛠 🧪 win🛠 wincairo🧪 ios-wk2🧪 api-gtk🧪 mac-wk1🧪 mac-AS-debug-wk2