[Xcode] Fix race condition when generating IDLFileNamesList.txt #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emw-apple
added
Tools / Tests
|
EWS run on previous version of this PR (hash 25e778e)
|
emw-apple
force-pushed
the
eng/fix-idl-names-race-condition
branch
from
25e778e
to
3599de2
Compare
|
EWS run on current version of this PR (hash 3599de2)
|
grorg
approved these changes
Oct 18, 2022
https://bugs.webkit.org/show_bug.cgi?id=246718 Reviewed by Dean Jackson. Change WebCore's DerivedSources.make to only generate IDLFileNamesList.txt *once*, before any invocations of preprocess-idls.pl. This fixes a race condition where one instance of preprocess-idls is reading the file while another Make thread is (unnecessarily) regenerating it. * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: Canonical link: https://commits.webkit.org/255709@main
webkit-commit-queue
force-pushed
the
eng/fix-idl-names-race-condition
branch
from
3599de2
to
244ca6a
Compare
|
Committed 255709@main (244ca6a): https://commits.webkit.org/255709@main Reviewed commits have been landed. Closing PR #5516 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
244ca6a
3599de2
🛠 🧪 win🛠 wincairo🧪 ios-wk2🧪 mac-AS-debug-wk2