New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LBSE] Fix transform support for SVG <text> elements #5534
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
nikolaszimmermann:eng/LBSE-Fix-transform-support-for-SVG-text-elements
Oct 20, 2022
Merged
[LBSE] Fix transform support for SVG <text> elements #5534
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
nikolaszimmermann:eng/LBSE-Fix-transform-support-for-SVG-text-elements
Oct 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikolaszimmermann
added
SVG
For bugs in the SVG implementation.
WebKit Local Build
labels
Oct 19, 2022
EWS run on current version of this PR (hash d38a030) |
rwlbuis
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
nikolaszimmermann
added
the
merge-queue
Applied to send a pull request to merge-queue
label
Oct 20, 2022
https://bugs.webkit.org/show_bug.cgi?id=245508 Reviewed by Rob Buis. RenderSVGBlock::referenceBoxRect() was missing (affecting RenderSVGText), thus the refeferenceBoxRect() for a RenderSVGText renderer was computed according to CSS rules, see RenderBox::referenceBoxRect(), and not according to the SVG rules, implemented in RenderLayerModelObject::referenceBoxRect() -- fix that. This also uncovered a LBSE specific isssue with SMIL <animateMotion> - they were post- instead of pre-multiplied, fix that as well, while I'm at it. Covered by numerous existing tests that now function properly in LBSE. * LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/batik/text/smallFonts-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/batik/text/textFeatures-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/custom/SVGPoint-matrixTransform-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/text/append-text-node-to-tspan-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/text/font-size-below-point-five-2-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/text/modify-text-node-in-tspan-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/text/remove-text-node-from-tspan-expected.txt: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/text/remove-tspan-from-text-expected.txt: * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::applySVGTransform const): (WebCore::RenderLayerModelObject::updateHasSVGTransformFlags): * Source/WebCore/rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::referenceBoxRect const): * Source/WebCore/rendering/svg/RenderSVGBlock.h: * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::applyTransform const): * Source/WebCore/rendering/svg/RenderSVGText.h: * Source/WebCore/svg/SVGGraphicsElement.cpp: (WebCore::SVGGraphicsElement::toClipPath): * Source/WebCore/svg/SVGGraphicsElement.h: (WebCore::SVGGraphicsElement::hasTransformRelatedAttributes const): * Source/WebCore/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath): Canonical link: https://commits.webkit.org/255801@main
webkit-early-warning-system
force-pushed
the
eng/LBSE-Fix-transform-support-for-SVG-text-elements
branch
from
October 20, 2022 21:07
d38a030
to
0c33f22
Compare
Committed 255801@main (0c33f22): https://commits.webkit.org/255801@main Reviewed commits have been landed. Closing PR #5534 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Oct 20, 2022
nikolaszimmermann
deleted the
eng/LBSE-Fix-transform-support-for-SVG-text-elements
branch
November 17, 2022 15:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0c33f22
d38a030