Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Fix absolute paths to macOS libraries in WebKit #5539

Merged
merged 1 commit into from Oct 19, 2022
Merged

[macOS] Fix absolute paths to macOS libraries in WebKit #5539

merged 1 commit into from Oct 19, 2022

Conversation

emw-apple
Copy link
Contributor

@emw-apple emw-apple commented Oct 19, 2022 •
edited by webkit-early-warning-system

de70c68

[macOS] Fix absolute paths to macOS libraries in WebKit
https://bugs.webkit.org/show_bug.cgi?id=246747
rdar://101228686

Reviewed by Alexey Proskuryakov.

* Source/WebKit/Configurations/WebKit.xcconfig: Replace absolute paths
  to dylibs with SDKROOT-relative paths to their respective TBDs.

Canonical link: https://commits.webkit.org/255751@main

2dcc72f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@emw-apple emw-apple self-assigned this Oct 19, 2022
@emw-apple emw-apple added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Oct 19, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 2dcc72f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@emw-apple emw-apple added the merge-queue Applied to send a pull request to merge-queue label Oct 19, 2022
@emw-apple
[macOS] Fix absolute paths to macOS libraries in WebKit
de70c68 
https://bugs.webkit.org/show_bug.cgi?id=246747
rdar://101228686

Reviewed by Alexey Proskuryakov.

* Source/WebKit/Configurations/WebKit.xcconfig: Replace absolute paths
  to dylibs with SDKROOT-relative paths to their respective TBDs.

Canonical link: https://commits.webkit.org/255751@main
@webkit-commit-queue
Copy link
Collaborator

Committed 255751@main (de70c68): https://commits.webkit.org/255751@main

Reviewed commits have been landed. Closing PR #5539 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit de70c68 into WebKit:main Oct 19, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aproskuryakov aproskuryakov aproskuryakov approved these changes

Assignees

@emw-apple emw-apple

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@emw-apple @webkit-early-warning-system @webkit-commit-queue @aproskuryakov