Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL compilation disabling WebGL 2 is broken #5544

Conversation

alexgcastro
Copy link
Contributor

@alexgcastro alexgcastro commented Oct 19, 2022

@alexgcastro alexgcastro self-assigned this Oct 19, 2022
@alexgcastro alexgcastro added WebGL Bugs in WebKit’s implementation of the WebGL standard. WebKit Nightly Build labels Oct 19, 2022
Copy link
Contributor

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me help review - seems fine. r+

@alexgcastro alexgcastro added the merge-queue Applied to send a pull request to merge-queue label Oct 20, 2022
https://bugs.webkit.org/show_bug.cgi?id=246753

Reviewed by Kenneth Russell.

WebGLVertexArrayObject is part of the WebGL 2 API but there are some
places in the code where it was added under the WEBGL ifdef instead of WEBGL2.

* Source/WebCore/inspector/InspectorCanvas.cpp:
* Source/WebCore/inspector/InspectorCanvasCallTracer.h:

Canonical link: https://commits.webkit.org/255778@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/WebGL-compilation-disabling-WebGL-2-is-broken branch from 6d4115d to 6b4ed06 Compare October 20, 2022 08:23
@webkit-commit-queue
Copy link
Collaborator

Committed 255778@main (6b4ed06): https://commits.webkit.org/255778@main

Reviewed commits have been landed. Closing PR #5544 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 6b4ed06 into WebKit:main Oct 20, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGL Bugs in WebKit’s implementation of the WebGL standard.
Projects
None yet
4 participants