Remove invalid assertion hit on 30 API tests since 255719@main #5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
WebKit Local Build
WebKit Misc.
cdumez
reviewed
Oct 19, 2022
| @@ -46,8 +46,6 @@ void FrameLoadState::removeObserver(Observer& observer) | |||
|
|
|||
| void FrameLoadState::didStartProvisionalLoad(const URL& url) | |||
| { | |||
| ASSERT(m_provisionalURL.isEmpty()); | |||
There was a problem hiding this comment.
I don't think this assertion is invalid. We hit it once in a while and every time it is a valid bug.
Seems to indicate duplicate didStartProvisionalLoad calls or a provisional load starting without the previous provisional load being cancelled first.
|
EWS run on previous version of this PR (hash c8cb29c)
|
achristensen07
force-pushed
the
eng/Remove-invalid-assertion-hit-on-30-API-tests-since-255719main
branch
from
c8cb29c
to
4f9c36f
Compare
|
EWS run on current version of this PR (hash 4f9c36f)
|
achristensen07
added
the
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=246759 rdar://101344112 Reviewed by Chris Dumez. * Source/WebKit/UIProcess/FrameLoadState.cpp: (WebKit::FrameLoadState::didStartProvisionalLoad): Canonical link: https://commits.webkit.org/255755@main
webkit-early-warning-system
force-pushed
the
eng/Remove-invalid-assertion-hit-on-30-API-tests-since-255719main
branch
from
4f9c36f
to
1431af1
Compare
|
Committed 255755@main (1431af1): https://commits.webkit.org/255755@main Reviewed commits have been landed. Closing PR #5550 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1431af1
4f9c36f
🛠 mac🛠 wpe🛠 mac-debug🛠 gtk🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress