[WGSL] Convert AST into string representation #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 8fc551c) |
litherum
approved these changes
Oct 20, 2022
|
EWS run on current version of this PR (hash a5e873c)
|
https://bugs.webkit.org/show_bug.cgi?id=246791 rdar://problem/101366942 Reviewed by Myles C. Maxfield. As a debugging aid, AST::Dumper converts a given WGSL AST into a string representation that approximates the original WGSL source code. Tested by ASTDumperTests. * Source/WebGPU/WGSL/AST/ASTDumper.cpp: Added. (WGSL::AST::Indent::Indent): (WGSL::AST::bumpIndent): (WGSL::AST::Dumper::visitVector): (WGSL::AST::Dumper::toString): (WGSL::AST::Dumper::visit): (WGSL::AST::dumpNode): (WGSL::AST::dumpAST): * Source/WebGPU/WGSL/AST/ASTDumper.h: Added. * Source/WebGPU/WGSL/AST/ASTVisitor.cpp: (WGSL::AST::Visitor::visit): * Source/WebGPU/WGSL/AST/ASTVisitor.h: * Source/WebGPU/WebGPU.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WGSL/ASTDumperTests.cpp: Added. (TestWGSLAPI::toString): (TestWGSLAPI::TEST): * Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp: (logCompilationError): Deleted. * Tools/TestWebKitAPI/Tests/WGSL/TestWGSLAPI.cpp: Added. (TestWGSLAPI::logCompilationError): * Tools/TestWebKitAPI/Tests/WGSL/TestWGSLAPI.h: Added. Canonical link: https://commits.webkit.org/255812@main
webkit-early-warning-system
force-pushed
the
wgsl/ast-dumper
branch
from
a5e873c
to
7e29ffc
Compare
|
Committed 255812@main (7e29ffc): https://commits.webkit.org/255812@main Reviewed commits have been landed. Closing PR #5575 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7e29ffc
a5e873c
🛠 mac🛠 wincairo🧪 gtk-wk2🧪 api-mac🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress